Page MenuHome
Differential D4285

Fix T60996: Dyntopo flood fill fails due to missing ob->imat
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 30 2019, 5:51 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T60996: Object mesh data is deleted when applying Detail Flood Fill using Constant Detail in Dyntopo sculpt mode.
Commits
rBSb5e93b02c9cf: Fix T60996: Dyntopo flood fill fails due to missing ob->imat
rBb5e93b02c9cf: Fix T60996: Dyntopo flood fill fails due to missing ob->imat
Summary

Not sure if there is a rule about when ob->imat should be updated and
when I can expect it to be updated already.

Also this patch reminds me of what I did some time ago in D3459.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Jan 30 2019, 5:51 PM
Harbormaster completed remote builds in B2804: Diff 13424.Jan 30 2019, 5:51 PM
Jacques Lucke (JacquesLucke) added a task: T60996: Object mesh data is deleted when applying Detail Flood Fill using Constant Detail in Dyntopo sculpt mode..Jan 30 2019, 5:52 PM
Brecht Van Lommel (brecht) added a comment.Jan 30 2019, 6:00 PM

Does adding imat copy to BKE_object_synchronize_to_original work?

After rB2e3433c1f7b8: Fix T60127: Particles texture mapping coordinates objects I think the intent is for this to be always up to date.

Jacques Lucke (JacquesLucke) updated this revision to Diff 13444.Jan 31 2019, 11:35 AM
  • set ob->imat in BKE_object_synchronize_to_original

Yes, that works.

Harbormaster completed remote builds in B2818: Diff 13444.Jan 31 2019, 11:35 AM
Brecht Van Lommel (brecht) accepted this revision.Jan 31 2019, 12:38 PM
This revision is now accepted and ready to land.Jan 31 2019, 12:38 PM
Closed by commit rBb5e93b02c9cf: Fix T60996: Dyntopo flood fill fails due to missing ob->imat (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJan 31 2019, 12:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
1 line

Diff 13449

View Options

source/blender/blenkernel/intern/object_update.c

Loading...