Fix T61051: crash with multi-object mixed mode snapping
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 31 2019, 1:04 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)

Maniphest Tasks

T61051: 2.8 crash - "selection to active" with bone selected in pose mode

Commits

rBSb294600ddcf1: Fix T61051: crash with multi-object mixed mode snapping
rBb294600ddcf1: Fix T61051: crash with multi-object mixed mode snapping

Summary

Fix T61051: crash with multi-object mixed mode snapping

rBec3357e03ab1 introduced multi-object snapping.
Seems like this was done without mixed-mode selections in mind.

So code assumes that all selected objects are actually armatures [which can fail].
In 2.7 this was not a problem, because code only took active object into account, 2.8 was iterating over all selected_editable_objects.

Now just iterate over objects in posemode instead

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jan 31 2019, 1:04 PM

Harbormaster completed remote builds in B2820: Diff 13450.Jan 31 2019, 1:04 PM

note: alternatively we could use BKE_view_layer_array_from_objects_in_mode instead of CTX_DATA_BEGIN (C, Object *, ob, selected_editable_objects) to be a bit more precise from the start?

BKE_view_layer_array_from_objects_in_mode is better indeed.
Besides remember to make comments full sentences, with capital letter at the beginning and a full stop in the end.

This revision now requires changes to proceed.Jan 31 2019, 10:11 PM