Page MenuHome

Fix T38928 Particle add brush would generate trash on meshes with use_modifier_stack enabled
ClosedPublic

Authored by Antonis Ryakiotakis (psy-fi) on Mar 26 2014, 10:03 PM.

Details

Summary

Issue here is complex (Of course, this is particles!)

First issue is that use_modifier_stack will use the num parameter of the
particles instead of num_dmcache, something the brush code did not
account for at all. Now correctly set DMCACHE_ISCHILD in that case.

Second issue is that make_derived_deform will return a mesh with less
indices than the particle system derived mesh. This would mean that
subsequent sampling of the particle derived mesh to initialize the
particles woould also produce garbage. This was being done for
optimization but in that case it broke the system.

Diff Detail

Event Timeline

Antonis Ryakiotakis (psy-fi) updated this revision to Unknown Object (????).Mar 26 2014, 10:11 PM
  • Recover old code that operated on deformed only mesh

This fixes the incorrect placement of hairs from brushes at least.

The actual hair distribution after exiting particle edit mode is still totally unrelated to the particle edit, but that's a different issue and a problem with particles in general. Would consider that out of scope.