Page MenuHome
Differential D430

Curve smooth respect cycles
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Mar 27 2014, 12:00 AM.

Details

Reviewers
Walid Shouman (walid)
Maniphest Tasks
T39441: Curve smooth ignores Cyclic

Diff Detail

Event Timeline

Walid Shouman (walid) added a reviewer: Campbell Barton (campbellbarton).Mar 27 2014, 12:06 AM
Campbell Barton (campbellbarton) added inline comments.Mar 27 2014, 12:27 AM
source/blender/editors/curve/editcurve.c
2473–2474
  • No need to set these for every x/y/z axis.
  • Theres no check for cyclic.
Campbell Barton (campbellbarton) requested changes to this revision.Mar 27 2014, 12:38 AM
Walid Shouman (walid) updated this revision to Unknown Object (????).Mar 27 2014, 12:42 AM
  • Removed ind_prev and ind_next out of dimensions' loop
  • Check cyclic before executing its behavior
Walid Shouman (walid) added inline comments.Mar 27 2014, 12:45 AM
source/blender/editors/curve/editcurve.c
2504

we could be a bit cryptic and make it for(bp = &nu->bp[bias], a = bias; a < nu->pntsu - bias; a++, bp++)
and only set bias = 0 or bias = 1 if cyclic flag was raised,

should you make it cryptic, or leave it very simple like that?

Campbell Barton (campbellbarton) added a comment.Mar 27 2014, 12:48 AM

Why not make smoothing into a static function that takes prev & next points, and a factor to smooth by.

Then having 2 different for loops wont do much duplication.

Walid Shouman (walid) updated this revision to Unknown Object (????).Mar 27 2014, 1:20 AM
  • Use static functions to smooth upon neighboring points for each of the BezTriple and BPoint curve points
Walid Shouman (walid) added inline comments.Mar 27 2014, 1:29 AM
source/blender/editors/curve/editcurve.c
2442

ops, missed to change this one :/

Walid Shouman (walid) updated this revision to Unknown Object (????).Mar 27 2014, 1:34 AM
  • Adding a missing factor propagation
Campbell Barton (campbellbarton) accepted this revision.Mar 27 2014, 11:28 PM

Committed with some cleanup rB7ff123ce5c08953a31f5728922be9d56c4ed850c

source/blender/editors/curve/editcurve.c
2429

Dont think this is needed - just BLI_assert(factor >= 0.0f && factor <= 1.0f)

2457

again, just remove.

Campbell Barton (campbellbarton) commandeered this revision.Mar 27 2014, 11:28 PM
Campbell Barton (campbellbarton) abandoned this revision.
Campbell Barton (campbellbarton) edited reviewers, added: Walid Shouman (walid); removed: Campbell Barton (campbellbarton).

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
curve/
66 lines

Diff 1345

View Options

source/blender/editors/curve/editcurve.c

Loading...