Page MenuHome
Differential D4315

Refactor drawing preview
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Feb 7 2019, 2:53 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBS005626b8c6b4: Refactors preview drawing code with few functional modifications:
rB005626b8c6b4: Refactors preview drawing code with few functional modifications:
Summary

Refactors preview drawing code with few functional modifications:

  • Fix T61241: Incorrect blank backdrop in VSE
  • Changing preview size does not affect drawn image size, only resolution.
    • Consistent behavior, when changing full-size / proxy / scene render size
    • Scopes are rendered in *same size* as source image
    • Over all, user does not have to readjust preview zoom.

Diff Detail

Event Timeline

Richard Antalik (ISS) created this revision.Feb 7 2019, 2:53 AM
Richard Antalik (ISS) updated this revision to Diff 13537.Feb 7 2019, 3:09 AM

Fix comment style
Remove unused variable

Richard Antalik (ISS) mentioned this in D3934: VSE cache with frame prefetching (WIP).Feb 18 2019, 2:50 AM
Richard Antalik (ISS) mentioned this in D4396: Fix VSE color picker.Feb 23 2019, 3:56 AM
Brecht Van Lommel (brecht) requested changes to this revision.Feb 25 2019, 5:37 PM

Great improvement, just one minor comment.

source/blender/editors/space_sequencer/sequencer_draw.c
1084

Since this is a private function it should be static, and not use the BKE_ prefix because it is not in blenkernel/.

This revision now requires changes to proceed.Feb 25 2019, 5:37 PM
Olly Funkster (Funkster) awarded a token.Feb 25 2019, 5:47 PM
Richard Antalik (ISS) updated this revision to Diff 13855.Feb 25 2019, 11:38 PM

Fix private function name.

Brecht Van Lommel (brecht) accepted this revision.Feb 26 2019, 12:35 PM
This revision is now accepted and ready to land.Feb 26 2019, 12:35 PM
Closed by commit rB005626b8c6b4: Refactors preview drawing code with few functional modifications: (authored by Richard Antalik (ISS)). · Explain WhyFeb 27 2019, 10:51 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) mentioned this in T64579: Failure to honor anamorphic display.May 15 2019, 11:48 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_sequencer/
576 lines
2 lines
4 lines

Diff 13855

View Options

source/blender/editors/space_sequencer/sequencer_draw.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_intern.h

Loading...
View Options

source/blender/editors/space_sequencer/space_sequencer.c

Loading...