Differential D4318

Various improvements in svg import: fixed handles in rectangulars
Needs ReviewPublic
Actions

Authored by Michael Soluyanov (crantisz) on Feb 7 2019, 1:39 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Summary

side by side: new version / old version / inkscape's convert to path:

imprt test.svg6 KBDownload

Diff Detail

Event Timeline

Michael Soluyanov (crantisz) created this revision.Feb 7 2019, 1:39 PM

Michael Soluyanov (crantisz) updated this revision to Diff 13551.Feb 7 2019, 1:54 PM

Is this a generic fix or specific for some files?
Did you test it with .svg files exported from other programs?

io_curve_svg/import_svg.py
1482	I already commented on that like, I don't think it is necessary to precompute this constant. Better explain why that formula is correct.

In D4318#98145, @Jacques Lucke (JacquesLucke) wrote:

Is this a generic fix or specific for some files?
Did you test it with .svg files exported from other programs?

This is specific for files with rect elements with rounded corners:

https://developer.mozilla.org/en-US/docs/Web/SVG/Element/rect

Round corner it is a quarter of circle, so the constant explanation:

https://stackoverflow.com/questions/1734745/how-to-create-circle-with-b%C3%A9zier-curves

Revision Contents
Changeset List

Path

Size

io_curve_svg/

import_svg.py

56 lines

Diff 13551

View Options

io_curve_svg/import_svg.py

Various improvements in svg import: fixed handles in rectangularsNeeds ReviewPublicActions