Details

Reviewers

Clément Foucault (fclem)
Campbell Barton (campbellbarton)

Commits

rB859f2561c858: Fix T61286: Viewport grid units not visible
rB3dbe17234471: Fix crash with no grid unit

Summary

The original code was commented on.
Unlike blender 2.79, the grid units are now displayed only when RV3D_VIEW_IS_AXIS.
The visible subdivisions in the grid are made by the GPU and depending on the pixel.
The code used here only mimics this behavior and adds a bit of overhead.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 4506
Build 4506: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Feb 8 2019, 4:15 PM

Harbormaster completed remote builds in B2861: Diff 13560.Feb 8 2019, 4:15 PM

Harbormaster completed remote builds in B2861: Diff 13560.

Germano Cavalcante (mano-wii) mentioned this in T61286: Viewport grid units should be visible.Feb 8 2019, 4:31 PM

This ignores unit scale - which should be easy to fix.

However I'm not sure this is a good approach
it's not working well especially for Imperial.

See screenshot

This revision now requires changes to proceed.Feb 11 2019, 6:26 AM

After analyzing I realized that the grid drawing and the unit levels in the imperial system (buImperialLenDef) doesn't match.
The drawing of the grid highlights 10 in 10. It's as if the units are:

"0.01 foot"
"0.1 foot"
"foot"
"10 feet"
...

I think it is important to resolve the drawing issue first :\

Use unit_scale to get a smooth transition between base_unit and drawing.

But this does not fix the problem of the units that are displayed.

Harbormaster completed remote builds in B2883: Diff 13605.Feb 11 2019, 3:46 PM

Germano Cavalcante (mano-wii) mentioned this in D4379: View3D Grid: fix drawing of grid with imperial units.Feb 19 2019, 5:49 PM

What is the status of this patch? People in devtalk are getting a little frustrated that this hasn’t been fixed.(not me)

I believe that at the current stage (close to the 2.80 release), this patch will have to be postponed to 2.81 :\
But it's always good to give a nudge (as you did) so this patch is not forgotten ;)

Rey Leonard M. Amorato (rl.amorato) added a subscriber: Rey Leonard M. Amorato (rl.amorato).Jul 13 2019, 8:51 PM

Germano Cavalcante (mano-wii) mentioned this in D5265: Restore grid spacing info in 3D views (as present in 2.79).Jul 16 2019, 7:44 PM

Forest Katsch (zlsa) added a subscriber: Forest Katsch (zlsa).Jul 16 2019, 11:42 PM

Yes, this is really missed here. Hope it gets back in soon. Having to ruler everything just to see scale is a pain.

Germano Cavalcante (mano-wii) mentioned this in rB4bf37bafc270: View3D Grid: fix imperial grid drawing.Aug 19 2019, 5:08 PM

Update to match master

Harbormaster completed remote builds in B4506: Diff 17282.Aug 19 2019, 7:05 PM

In D4325#98106, @Campbell Barton (campbellbarton) wrote:

This ignores unit scale - which should be easy to fix.

However I'm not sure this is a good approach
it's not working well especially for Imperial.

See screenshot

I didn't understand the unit scale issue but I believe that both this and the other problem mentioned were fixed.