Details
Details
- Reviewers
Walid Shouman (walid) - Maniphest Tasks
- T38317: Randomize (vertices)
Diff Detail
Diff Detail
Event Timeline
| release/scripts/startup/bl_ui/space_view3d_toolbar.py | ||
|---|---|---|
| 468 | should we make a wrapper operator for the curves (and bones, surfaces ... ) (ie curve.point_rand) now ? | |
Comment Actions
Looks good, minor suggestions.
- object_rand_verts_poll could be a generic poll function, apart of ED_transverts.h api. Just a wrapper for ED_transverts_check_obedit
- Maybe its a good time to have a BLI_frand_v3() function, this is a common operation.
Comment Actions
- A generic poll function for ED_transverts objects
- Generating random vectors
- Support sub_v*_fl functions similar to add_v*_fl functions
| source/blender/editors/object/object_rand.c | ||
|---|---|---|
| 104 | QT complains about it for not being used! PropertyRNA *prop;
^is there a missing thing in this usage? | |
| source/blender/editors/object/object_rand.c | ||
|---|---|---|
| 104 | Just remove it theres no reason to have it. | |
Comment Actions
In general ok, but dont think sub_v3_fl(vec, 0.5); is needed, just do add_v3_fl(vec, -0.5);
Comment Actions
Think this is generally good, Id like to apply the patch and do some final checks though before its committed to master.