Changed units to correct ones
ClosedPublic
Actions

Authored by Vaishnav S (padthai) on Feb 11 2019, 5:22 PM.

Details

Reviewers

William Reynish (billreynish)
Jacques Lucke (JacquesLucke)

Maniphest Tasks

T60824: List of Properties that should use the Units system

Commits

rBS22eeae810450: Units: Fix some property subtypes
rB22eeae810450: Units: Fix some property subtypes

Summary

This revision is related to T60824.

Corrected units in Dynamic Paint, Modifiers (Wave, Wireframe), Smoke and Forcefield.
Also what's a suitable unit for flow_settings.texture_offset? Would PROP_UNIT_LENGTH be fine or should it be left at PROP_NONE for now?

Diff Detail

Event Timeline

Vaishnav S (padthai) created this revision.Feb 11 2019, 5:22 PM

Brecht Van Lommel (brecht) edited reviewers, added: Jacques Lucke (JacquesLucke); removed: Brecht Van Lommel (brecht).Feb 11 2019, 5:23 PM

Vaishnav S (padthai) added a task: T60824: List of Properties that should use the Units system.Feb 11 2019, 5:26 PM

Looks correct to me. @Jacques Lucke (JacquesLucke) ?

This revision is now accepted and ready to land.Feb 11 2019, 7:21 PM

Jacques Lucke (JacquesLucke) added inline comments.Feb 12 2019, 3:10 PM

source/blender/makesrna/intern/rna_modifier.c
1830	This speed and the `dry_speed` seem to work in opposite ways.
source/blender/makesrna/intern/rna_object_force.c
1279	I already commented on this one somewhere else. Sometimes this seems to be a distance and sometimes an angle.
source/blender/makesrna/intern/rna_smoke.c
851	I don't understand why this thickness is a length. Shouldn't it be more like a density?

Vaishnav S (padthai) added inline comments.Feb 12 2019, 5:09 PM

source/blender/makesrna/intern/rna_modifier.c
1830	Will there be any changes in the units though?
source/blender/makesrna/intern/rna_smoke.c
851	What do you propose it should be? Thought of using PROP_VOLUME, but this seemed more suitable.

A separate density unit could also be made I guess; could be useful for some more properties.

We should probably start by simply fixing everything using the current unit types. Then we can make a note of the missing unit types and implement then later.

Corrected units in Modifiers (Bevel width), Scene and Curve.

William Reynish (billreynish) edited the summary of this revision. (Show Details)Feb 19 2019, 1:58 PM

Closed by commit rB22eeae810450: Units: Fix some property subtypes (authored by Vaishnav S (padthai), committed by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 19 2019, 3:29 PM

This revision was automatically updated to reflect the committed changes.