Fix T61499: Missing Camera settings in props except Depth of Field
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Feb 13 2019, 10:17 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
William Reynish (billreynish)

Maniphest Tasks

T61499: Missing Camera settings in props except Depth of Field

Commits

rBS5e3838faa2e6: Fix T61499: Missing Camera settings in props except Depth of Field
rB5e3838faa2e6: Fix T61499: Missing Camera settings in props except Depth of Field

Summary

rB55c281415b67 removed 'BLENDER_RENDER' as a COMPAT_ENGINE but the
cycles addon checks for this in its get_panels() function.

Adding this back for now.
(Not sure if it makes sense to do a cleanup and replace 'BLENDER_RENDER'
with 'CYCLES' throughout ui scripts? -- cycles addon as well as other
addons would probably require some adjustments...)

Diff Detail

Repository

rB Blender

Branch

T61499 (branched from master)

Build Status

Buildable 2908
Build 2908: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Feb 13 2019, 10:17 AM

Harbormaster completed remote builds in B2908: Diff 13644.Feb 13 2019, 10:17 AM

Philipp Oeser (lichtwerk) mentioned this in T61499: Missing Camera settings in props except Depth of Field.Feb 13 2019, 10:23 AM

Brecht Van Lommel (brecht) accepted this revision.Feb 13 2019, 12:09 PM

This revision is now accepted and ready to land.Feb 13 2019, 12:09 PM

Oh, sorry for this. My mistake. I thought Blender Render = Blender Internal?

Elsewhere we check for Cycles specifically, why don't we do the same here?

Closed by commit rB5e3838faa2e6: Fix T61499: Missing Camera settings in props except Depth of Field (authored by Philipp Oeser (lichtwerk)). · Explain WhyFeb 13 2019, 12:35 PM

This revision was automatically updated to reflect the committed changes.

BLENDER_RENDER is a tag for render panels that add-on render engines (including Cycles) keep visible by default, unless they specifically decide to hide it.

It lets us add or remove panels in a way that keeps add-ons working well in most cases.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

properties_data_camera.py

24 lines

Diff 13644

View Options

release/scripts/startup/bl_ui/properties_data_camera.py

Fix T61499: Missing Camera settings in props except Depth of FieldClosedPublicActions