Fix T61707: Use id attribute to initialize object and curve names
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 19 2019, 2:24 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T61707: Read SVG id-attribute for lines, polygons, etc. as it's already done for path and ellipsis

Commits

rBAb1320f3af626: Fix T61707: Use id attribute to initialize object and curve names

Summary

That was more a feature request than a bug, but still a nice to have.

Diff Detail

Repository

rBA Blender Add-ons

Branch

svg-import-names

Build Status

Buildable 2955
Build 2955: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Feb 19 2019, 2:24 PM

Harbormaster completed remote builds in B2954: Diff 13740.Feb 19 2019, 2:24 PM

Jacques Lucke (JacquesLucke) added a task: T61707: Read SVG id-attribute for lines, polygons, etc. as it's already done for path and ellipsis.Feb 19 2019, 2:25 PM

Sergey Sharybin (sergey) added inline comments.Feb 19 2019, 3:12 PM

io_curve_svg/import_svg.py
457	Would only pass `object` here, and assign name of `object` and `object.data`.

cleanup

Originally wanted to be explicit that the name of the object and curve are
changed, but this is fine as well.

Harbormaster completed remote builds in B2955: Diff 13744.Feb 19 2019, 3:34 PM

Jacques Lucke (JacquesLucke) marked an inline comment as done.Feb 19 2019, 3:34 PM

Sergey Sharybin (sergey) accepted this revision.Feb 19 2019, 3:36 PM

This revision is now accepted and ready to land.Feb 19 2019, 3:36 PM

Closed by commit rBAb1320f3af626: Fix T61707: Use id attribute to initialize object and curve names (authored by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 19 2019, 3:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

io_curve_svg/

import_svg.py

16 lines

Diff 13744

View Options

io_curve_svg/import_svg.py

Fix T61707: Use id attribute to initialize object and curve namesClosedPublicActions