Page MenuHome
Differential D4383

Cycles OpenCL: Remove OpenCL MegaKernel
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Feb 20 2019, 10:38 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Group Reviewers
Cycles
Commits
rC0b020876cbe3: Cycles OpenCL: Remove OpenCL MegaKernel
rBS949ab753bb2e: Cycles OpenCL: Remove OpenCL MegaKernel
rB949ab753bb2e: Cycles OpenCL: Remove OpenCL MegaKernel
Summary

Using OpenCL MegaKernel has been slow and therefore not usefull.
This patch will remove the mega kernel from the OpenCL codebase
and the OpenCLDeviceBase class.

T61736: removal of mega kernel
T61703: baking does not work with mega kernel

Diff Detail

Repository
rB Blender
Branch
arcpatch-D4383 (branched from blender2.7)
Build Status
Buildable 2963
Build 2963: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Feb 20 2019, 10:38 AM
Harbormaster completed remote builds in B2962: Diff 13762.Feb 20 2019, 10:38 AM
Jeroen Bakker (jbakker) planned changes to this revision.Feb 20 2019, 10:38 AM
Jeroen Bakker (jbakker) added reviewers: Cycles, Brecht Van Lommel (brecht).
Jeroen Bakker (jbakker) added a project: Cycles.

Rename OpenCLDeviceBase to OpenCLDeviceSplitKernel

Jeroen Bakker (jbakker) updated this revision to Diff 13763.Feb 20 2019, 10:46 AM

Renamed OpenCLDeviceBase to OpenCLDeviceSplitKernel

Harbormaster completed remote builds in B2963: Diff 13763.Feb 20 2019, 10:46 AM
Brecht Van Lommel (brecht) requested changes to this revision.Feb 20 2019, 1:09 PM

Seems fine, just minor comment.

intern/cycles/device/opencl/opencl.h
261

Can we just call this OpenCLDevice?

This revision now requires changes to proceed.Feb 20 2019, 1:09 PM
Jeroen Bakker (jbakker) updated this revision to Diff 13770.Feb 20 2019, 2:42 PM

Renamed OpenCLDeviceSplitKernel to OpenCLDevice

Harbormaster completed remote builds in B2964: Diff 13770.Feb 20 2019, 2:42 PM
Harbormaster completed remote builds in B2964: Diff 13770.
Jeroen Bakker (jbakker) marked an inline comment as done.Feb 20 2019, 2:43 PM
Brecht Van Lommel (brecht) accepted this revision.Feb 20 2019, 3:08 PM
This revision is now accepted and ready to land.Feb 20 2019, 3:08 PM
Closed by commit rB949ab753bb2e: Cycles OpenCL: Remove OpenCL MegaKernel (authored by Jeroen Bakker (jbakker)). · Explain WhyFeb 20 2019, 3:18 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rC0b020876cbe3: Cycles OpenCL: Remove OpenCL MegaKernel.Aug 22 2019, 5:13 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
addon/
1 line
20 lines
device/
2 lines
18 lines
opencl/
10 lines
6 lines
78 lines
1865 lines
75 lines
kernel/
2 lines
kernels/
opencl/
62 lines
util/
3 lines
24 lines

Diff 13763

View Options

intern/cycles/blender/addon/ui.py

Loading...
View Options

intern/cycles/blender/blender_python.cpp

Loading...
View Options

intern/cycles/device/CMakeLists.txt

Loading...
View Options

intern/cycles/device/device_opencl.cpp

Loading...
View Options

intern/cycles/device/opencl/memory_manager.h

Loading...
View Options

intern/cycles/device/opencl/memory_manager.cpp

Loading...
View Options

intern/cycles/device/opencl/opencl.h

Loading...
View Options

intern/cycles/device/opencl/opencl_base.cpp

Loading...
View Options

intern/cycles/device/opencl/opencl_mega.cpp

Loading...
View Options

intern/cycles/device/opencl/opencl_split.cpp

Loading...
View Options

intern/cycles/device/opencl/opencl_util.cpp

Loading...
View Options

intern/cycles/kernel/CMakeLists.txt

Loading...
View Options

intern/cycles/kernel/kernels/opencl/kernel.cl

Loading...
View Options

intern/cycles/kernel/kernels/opencl/kernel_base.cl

Loading...
View Options

intern/cycles/util/util_debug.h

Loading...
View Options

intern/cycles/util/util_debug.cpp

Loading...