Page MenuHome

Cycles OpenCL: Remove OpenCL MegaKernel
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Feb 20 2019, 10:38 AM.

Details

Summary

Using OpenCL MegaKernel has been slow and therefore not usefull.
This patch will remove the mega kernel from the OpenCL codebase
and the OpenCLDeviceBase class.

T61736: removal of mega kernel
T61703: baking does not work with mega kernel

Diff Detail

Repository
rB Blender
Branch
arcpatch-D4383 (branched from blender2.7)
Build Status
Buildable 2963
Build 2963: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) planned changes to this revision.Feb 20 2019, 10:38 AM

Rename OpenCLDeviceBase to OpenCLDeviceSplitKernel

Renamed OpenCLDeviceBase to OpenCLDeviceSplitKernel

Brecht Van Lommel (brecht) requested changes to this revision.Feb 20 2019, 1:09 PM

Seems fine, just minor comment.

intern/cycles/device/opencl/opencl.h
261

Can we just call this OpenCLDevice?

This revision now requires changes to proceed.Feb 20 2019, 1:09 PM

Renamed OpenCLDeviceSplitKernel to OpenCLDevice

Harbormaster completed remote builds in B2964: Diff 13770.
Jeroen Bakker (jbakker) marked an inline comment as done.Feb 20 2019, 2:43 PM
This revision is now accepted and ready to land.Feb 20 2019, 3:08 PM
This revision was automatically updated to reflect the committed changes.