Page MenuHome

Fix T61788: Hidden objects reappear after rendering
ClosedPublic

Authored by Dalai Felinto (dfelinto) on Feb 22 2019, 3:16 PM.

Details

Summary

The change in outliner and viewport visibility (897e047374fa) was made
assuming the bases of the render and viewport depsgraph were
independent. Thus we were deliberately setting base visibility when
rendering:

/* When rendering, visibility is controlled by the enable/disable option. */
if (mode == DAG_EVAL_RENDER) {
    base->flag |= BASE_VISIBLE;
}

However, we were syncing data back to the original depsgraph, leading to
hidden viewport objects to re-appear.

Diff Detail

Repository
rB Blender
Branch
fix-T61788-deg-show-hidden-render-v3d (branched from master)
Build Status
Buildable 2976
Build 2976: arc lint + arc unit

Event Timeline

Think it should be checking for the dependency graph being active rather then for being viewport.

From review: use active DEG, not viewport.

This seems fine to me, but i can't really test and verify it atm.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2019, 3:54 PM
This revision was automatically updated to reflect the committed changes.