Page MenuHome
Differential D4396

Fix VSE color picker
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Feb 23 2019, 3:56 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBSa761a93d411d: Fix VSE color picker
rBa761a93d411d: Fix VSE color picker
Summary

Fix VSE color picker mouse coords calculation

Diff Detail

Event Timeline

Richard Antalik (ISS) created this revision.Feb 23 2019, 3:56 AM
Richard Antalik (ISS) mentioned this in D4389: Fix strips text offset when zooming VSE timeline.Feb 23 2019, 3:28 PM
Brecht Van Lommel (brecht) requested changes to this revision.Feb 25 2019, 5:42 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/blenkernel/BKE_sequencer.h
243

This should get a BKE_sequencer prefix since it's now exposed as a public function.

This revision now requires changes to proceed.Feb 25 2019, 5:42 PM
Richard Antalik (ISS) updated this revision to Diff 14208.Mar 16 2019, 12:51 AM
Richard Antalik (ISS) edited the summary of this revision. (Show Details)

I am dividing by scene->r.*sch - should I check for zero?

Brecht Van Lommel (brecht) accepted this revision.Mar 18 2019, 12:05 PM

No need to check for zero, this value is guaranteed to be higher.

This revision is now accepted and ready to land.Mar 18 2019, 12:05 PM
Closed by commit rBa761a93d411d: Fix VSE color picker (authored by Richard Antalik (ISS)). · Explain WhyMar 18 2019, 9:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
1 line
intern/
2 lines
editors/
space_sequencer/
14 lines
24 lines

Diff 13810

View Options

source/blender/blenkernel/BKE_sequencer.h

Loading...
View Options

source/blender/blenkernel/intern/sequencer.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_draw.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_view.c

Loading...