Grease Pencil Depth Order Names
ClosedPublic
Actions

Authored by William Reynish (billreynish) on Feb 25 2019, 1:13 PM.

Details

Reviewers

Group Reviewers

Commits

rBS54ffc4e19dc4: Grease Pencil naming: Use clear names for depth ordering
rB54ffc4e19dc4: Grease Pencil naming: Use clear names for depth ordering

Summary

The two features for depth ordering Grease Pencil objects and strokes have very misleading names and tooltips.

Even though object depth ordering was called X-Ray Mode, it had no connection to X-Ray at all.
The 'Mode' property was not descriptive
Internally calling it draw_mode is confusing as it has nothing to do with how the item is drawn, only the depth ordering
We don't use the term 'draw' for display properties. We call those 'display'. Using 'draw' is fundamentally confusing inside an app that includes actual drawing tools.

Also, the Keep Thickness property is not clear. Keep from what? Here I changed it to become an enum with each state being clear.

Here's an update that fixes this.

Before:

After:

Diff Detail

Event Timeline

William Reynish (billreynish) created this revision.Feb 25 2019, 1:13 PM

William Reynish (billreynish) edited the summary of this revision. (Show Details)Feb 25 2019, 1:16 PM

yes, totally agree with the names change @William Reynish (billreynish)

We should probably also rename Keep Thickness to become an enum called 'Stroke Thickness' with two options: 'World Space' and 'Screen Space'.

'Keep Thickness' doesn't really communicate clearly what the purpose is. Keep the thickness from what?

Added Stroke Thickness enum to replace Keep Thickness.

@Antonio Vazquez (antoniov) If you accept this I can also commit. Or you can do it too - up to you.

@William Reynish (billreynish) If you have tested, for me the code it's ok and you can commit.

This revision is now accepted and ready to land.Feb 25 2019, 3:57 PM

Maybe this shouldn't be under "viewport display" subpanel, but under a depth order one, since "viewport display" seemps to imply this will only affect how it is shown in the viewport, not how it will be rendered.

@Tomas (Rusculleda): I agree. I will split off all the items that are only for the viewport away from the items that apply generally.

The convention in Blender is that the Viewport Display panel only includes properties that apply to the viewport only.

Closed by commit rB54ffc4e19dc4: Grease Pencil naming: Use clear names for depth ordering (authored by William Reynish (billreynish)). · Explain WhyFeb 25 2019, 9:59 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) mentioned this in rBf6bafef1e1a8: GPencil: Move Object Depth Order to Object.Mar 4 2019, 5:06 PM