Page MenuHome
Differential D4407

Refactor CDData masks, to have one mask per mesh elem type.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Feb 25 2019, 5:40 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Sergey Sharybin (sergey)
Commits
rBSab0bc65c24bd: Refactor CDData masks, to have one mask per mesh elem type.
rBab0bc65c24bd: Refactor CDData masks, to have one mask per mesh elem type.
Summary

We already have different storages for cddata of verts, edges etc.,
'simply' do the same for the mask flags we use all around Blender code
to request some data, or limit some operation to some layers, etc.

Reason we need this is that some cddata types (like Normals) are
actually shared between verts/polys/loops, and we don’t want to generate
clnors everytime we request vnors!

Some notes:

  • This is probably better for after Spring render crunch (while nothing especially risky here, the size of the patch makes it quiet sensible to typos/copy/paste mistakes and the like :/ ).
  • Naming is open to discussion, this is merely 'placeholder' names I used for CustomData_Masks struct especially.
  • DEG area does not seems to be keen to re-use C structs, so for now just put all five masks as raw uint64_t values, guess this is not the way to go here, just not sure how to do it?
  • Use case triggering that patch: T59338, for datatransfer modifier I need to be able to request CD_NORMAL on loops for 'target' (aka source) object.

Diff Detail

Repository
rB Blender

Event Timeline

Bastien Montagne (mont29) created this revision.Feb 25 2019, 5:40 PM
Harbormaster completed remote builds in B2993: Diff 13850.Feb 25 2019, 5:40 PM
Bastien Montagne (mont29) edited the summary of this revision. (Show Details)Feb 25 2019, 5:45 PM
Campbell Barton (campbellbarton) requested changes to this revision.EditedFeb 26 2019, 3:02 AM

Generally seems straightforward reasonable changes, only minor comments.

  • CustomData_Masks is mesh spesific since it deals with vert/edge/face.. etc, we may want to use custom-data for curves in the future, think it would be best to include Mesh in the name.
  • The struct is passed by value in a few places, since it's 40 bytes, better to pass as a pointer, mesh_create_derived_render, mesh_create_derived_view for eg.
  • const isn't used consistently editbmesh_build_data, CustomData_Masks_are_matching, mesh_get_derived_final for eg.
This revision now requires changes to proceed.Feb 26 2019, 3:02 AM
Bastien Montagne (mont29) added a comment.Feb 26 2019, 11:34 AM

Thanks for the quick review. :)

In D4407#100114, @Campbell Barton (campbellbarton) wrote:

Generally seems straightforward reasonable changes, only minor comments.

  • CustomData_Masks is mesh spesific since it deals with vert/edge/face.. etc, we may want to use custom-data for curves in the future, think it would be best to include Mesh in the name.

Hrmmmm… yes and no? Good point, but if we use cddata for other datatypes in the future, do we really want to add another struct to handle them? Or instead, use unions inside of a single struct? Not sure, just asking. ;)

  • The struct is passed by value in a few places, since it's 40 bytes, better to pass as a pointer, mesh_create_derived_render, mesh_create_derived_view for eg.
  • const isn't used consistently editbmesh_build_data, CustomData_Masks_are_matching, mesh_get_derived_final for eg.

Well, idea here was to pass by value in public functions when internal code could alter the mask for its own usage… But agree it's probably simpler to always pass by (const) pointer, and make copy inside functions when needed. Should be done by now.

Bastien Montagne (mont29) updated this revision to Diff 13860.Feb 26 2019, 11:35 AM
  • Move all CustomData_Masks parameters to pointers.
Harbormaster completed remote builds in B2998: Diff 13860.Feb 26 2019, 11:35 AM
Campbell Barton (campbellbarton) added a comment.Feb 26 2019, 12:06 PM
In D4407#100155, @Bastien Montagne (mont29) wrote:

Thanks for the quick review. :)

In D4407#100114, @Campbell Barton (campbellbarton) wrote:

Generally seems straightforward reasonable changes, only minor comments.

  • CustomData_Masks is mesh spesific since it deals with vert/edge/face.. etc, we may want to use custom-data for curves in the future, think it would be best to include Mesh in the name.

Hrmmmm… yes and no? Good point, but if we use cddata for other datatypes in the future, do we really want to add another struct to handle them? Or instead, use unions inside of a single struct? Not sure, just asking. ;)

Custom data API only has two small functions that take CustomData_Masks and think it's reasonable they be identified as mesh functions (could even be moved out of customdata.c). It just means later on if curves support customdata we don't have odd naming or more large struct member renaming.

Bastien Montagne (mont29) added a comment.Feb 26 2019, 5:42 PM

OK, so something like CustomData_MeshMasks (for the struct and the two functions)?

Bastien Montagne (mont29) added a comment.Feb 26 2019, 5:43 PM

@Sergey Sharybin (sergey) would love to hear from you re best way to store those bitflags in DEG data structs? WOuld not consider current solution a really nice one… ;)

Sergey Sharybin (sergey) requested changes to this revision.Feb 26 2019, 6:24 PM
Sergey Sharybin (sergey) added inline comments.
source/blender/depsgraph/DEG_depsgraph_build.h
165

Think you're missing forward declaration of CustomData_Masks.

source/blender/depsgraph/intern/builder/deg_builder.cc
206–207

Have those wrapped into a single structure, with an overloaded comparison operator.

source/blender/depsgraph/intern/builder/deg_builder_nodes.cc
157–158

Why all this complexity? In the entire file of this change?

source/blender/depsgraph/intern/builder/deg_builder_nodes.h
233–234

Not sure why you chose that. There is nothing what is really preventing you from using CustomData_MeshMasks here.

source/blender/depsgraph/intern/builder/deg_builder_relations.cc
1140–1142

You can easily think of a cleaner way of calling this.

Idea one:

add_customdata_mask(ct->tar, LayerSource::VERTEX, CD_MASK_NORMAL);
add_customdata_mask(ct->tar, LayerSource::LOOP, CD_MASK_CUSTOMLOOPNORMAL);

Idea two:

add_customdata_mask(ct->tar, CDMaskVertex(CD_MASK_NORMAL));
add_customdata_mask(ct->tar, CDMaskLoop(CD_MASK_CUSTOMLOOPNORMAL));

Idea three:

add_customdata_mask(ct->tar, CDMaskVertex(CD_MASK_NORMAL) | CDMaskLoop(CD_MASK_CUSTOMLOOPNORMAL));
source/blender/depsgraph/intern/builder/deg_builder_relations.h
209–213

This is error prone, the calls are not readable, and is also confusing because object is not necessary a mesh.

There is already a mistake of calling vmasksimply mask here.

I also don't want those one letter stuff in my code. It is vertex_mask not vmask.

source/blender/depsgraph/intern/depsgraph_query.cc
126

This changes behavior from returning 0 for non-existing node to keep-at-garbage(stack-allocated) value.
It is to be at least documented in the comment of DEG_get_customdata_mask_for_objectabout what happens if object is not found.

source/blender/depsgraph/intern/node/deg_node_id.h
87–89

This should really be one property for current and one property for previous one.

Can either use CustomData_Mask, or some DEG specific variation with all the handy operations overloaded for it.

This revision now requires changes to proceed.Feb 26 2019, 6:24 PM
Bastien Montagne (mont29) edited the summary of this revision. (Show Details)Feb 28 2019, 2:06 PM
Bastien Montagne (mont29) marked 6 inline comments as done.
Bastien Montagne (mont29) added inline comments.
source/blender/depsgraph/intern/builder/deg_builder_nodes.h
233–234

As said previously, did not know how that kind of things was supposed to be handled in DEG, so just went for a temp stupid basic solution to get the rest f the code working first...

source/blender/depsgraph/intern/depsgraph_query.cc
126

I don’t mind adding back a return value (a bool?) to mark that object was not found, but not sure how useful that would be?

As for 'keep-as-garbage', that is kind of general new behavior for functions generating some cddata masking, they all now append to given mask, instead of fully setting its values. This allows to only pass around pointers, and cope for the lack of bitwise OR op for the C struct...

Bastien Montagne (mont29) updated this revision to Diff 13924.Feb 28 2019, 2:08 PM
Bastien Montagne (mont29) marked an inline comment as done.
Bastien Montagne (mont29) edited the summary of this revision. (Show Details)
  • Move all CustomData_Masks parameters to pointers.
  • Rename to CustomData_MeshMasks, and do suggested changes in DEG area.
Harbormaster completed remote builds in B3019: Diff 13924.Feb 28 2019, 2:08 PM
Bastien Montagne (mont29) updated this revision to Diff 13936.Feb 28 2019, 9:15 PM

Updated against latest master.

Harbormaster completed remote builds in B3024: Diff 13936.Feb 28 2019, 9:15 PM
Campbell Barton (campbellbarton) accepted this revision.Feb 28 2019, 10:41 PM
Erick Tukuniata (erickblender) added a subscriber: Erick Tukuniata (erickblender).Feb 28 2019, 11:05 PM

Yo @Bastien Montagne (mont29) is this beneficial to multires. somehow?

Bastien Montagne (mont29) added a comment.Mar 1 2019, 11:53 AM

@Erick Tukuniata (erickblender) not sure what you mean here? Probably not though, this some rather low-level change that might potentially benefit to many things involving meshes, but that specific patch is intended to be as 'transparent' as possible, not changing anything to existing behaviors.

Bastien Montagne (mont29) added a comment.Mar 1 2019, 11:54 AM

@Brecht Van Lommel (brecht) @Sergey Sharybin (sergey) you guys are in the Spring turmoil, what’s your feeling about this patch regarding that? I think it should rather wait for after rendering is done? If so, any idea when that might be?

Sergey Sharybin (sergey) added inline comments.Mar 1 2019, 12:36 PM
source/blender/depsgraph/intern/builder/deg_builder_relations.cc
316

DEG_CustomData_MeshMasks() ?

source/blender/depsgraph/intern/depsgraph_type.h
75

Probably ok for now. But maybe consider adding depsgraph_customdata.h and depsgraph_customdata_impl.h.

79

Don't mix snake style with camel case.
Types are to start with capital and be camel case.

80–84

Use CustomData_MeshMasks.

85

Add default constructor, which initializes masks to 0.
Also, probably worth adding constructor from CustomData_MeshMasks.

96

a -> other.

98

I would do it as

DEGCustomDataMeshMasks result;
result.vert_mask = this.vert_mask | other.vert_mask;
...

Might be looking more verbose, but is way less fragile.

106

bool operator==(const DEG_CustomData_MeshMasks& other) const with all the equality and then
bool operator!=(const DEG_CustomData_MeshMasks& a) const { return !(*this == other);

117

DEGCustomDataMeshMasks result;
result.vert_mask = vert_mask;
return result;

Sergey Sharybin (sergey) requested changes to this revision.Mar 1 2019, 12:37 PM
This revision now requires changes to proceed.Mar 1 2019, 12:37 PM
Bastien Montagne (mont29) updated this revision to Diff 13974.Mar 3 2019, 5:17 PM
Bastien Montagne (mont29) marked 7 inline comments as done.
  • Updates in DEG code from review.
Harbormaster completed remote builds in B3038: Diff 13974.Mar 3 2019, 5:17 PM
Bastien Montagne (mont29) added inline comments.Mar 3 2019, 5:17 PM
source/blender/depsgraph/intern/depsgraph_type.h
75

Not sure what should go into depsgraph_customdata_impl.h… Wouldn’t we rather need a depsgraph_customdata.cc ?

80–84

Don’t understand that one? That would make something like CustomData_MeshMasks masks;, and then would have to access the masks with customdata_masks.masks.vmask? Also implies that we include DNA_customdata_types.h here...

Or did you mean 'Use CustomDataMask' (from BKE_customdata.h's typedef uint64_t CustomDataMask;)?

Bastien Montagne (mont29) mentioned this in T62228: Data Transfer Modifier .Mar 5 2019, 10:04 PM
Bastien Montagne (mont29) updated this revision to Diff 14011.Mar 5 2019, 10:25 PM

Update against latest master.

Harbormaster completed remote builds in B3055: Diff 14011.Mar 5 2019, 10:25 PM
Sergey Sharybin (sergey) accepted this revision.Mar 6 2019, 11:29 AM

Some minor feedback.
Otherwise seems good.

source/blender/depsgraph/intern/depsgraph_type.cc
56–61

Technically style is:

DEG::DEGCustomDataMeshMasks::DEGCustomDataMeshMasks(const CustomData_MeshMasks *other)
        : vert_mask(other->vmask),
          edge_mask(other->emask),
          face_mask(other->fmask),
          loop_mask(other->lmask),
          poly_mask(other->pmask)
{
}
source/blender/depsgraph/intern/depsgraph_type.h
92

Mark as explicit.

Also not sure why implementation of this specific constructor is in .cc file.
Feels weird to have this scattered. Is it going from the fear of using includes from a header file?

This revision is now accepted and ready to land.Mar 6 2019, 11:29 AM
Sergey Sharybin (sergey) mentioned this in T61870: Eevee Shading Error- Object's go completely black if they have a normal map..Mar 6 2019, 12:03 PM
Bastien Montagne (mont29) marked 2 inline comments as done.Mar 6 2019, 4:10 PM
Bastien Montagne (mont29) added inline comments.
source/blender/depsgraph/intern/depsgraph_type.h
92

Also not sure why implementation of this specific constructor is in .cc file.
Feels weird to have this scattered. Is it going from the fear of using includes from a header file?

Yes, did not want to have to include DNA_customdata_types.h in that header

Bastien Montagne (mont29) updated this revision to Diff 14028.Mar 6 2019, 4:12 PM
Bastien Montagne (mont29) marked an inline comment as done.

Updates in DEG code from review, update against latest master.

Harbormaster completed remote builds in B3061: Diff 14028.Mar 6 2019, 4:12 PM
Sergey Sharybin (sergey) accepted this revision.Mar 7 2019, 11:06 AM

Code looks fine now.
Is there any aspects of review/testing you're awaiting?

Bastien Montagne (mont29) added a comment.Mar 7 2019, 11:11 AM

No am doing it right now, just did not want to commit that late in the evening ;)

Closed by commit rBab0bc65c24bd: Refactor CDData masks, to have one mask per mesh elem type. (authored by Bastien Montagne (mont29)). · Explain WhyMar 7 2019, 11:31 AM
This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 128 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
source/
blender/
alembic/
intern/
2 lines
8 lines
2 lines
blenkernel/
18 lines
8 lines
21 lines
2 lines
2 lines
9 lines
25 lines
21 lines
3 lines
intern/
308 lines
41 lines
10 lines
180 lines
43 lines
2 lines
2 lines
30 lines
39 lines
14 lines
23 lines
12 lines
4 lines
10 lines
4 lines
21 lines
7 lines
1 line
5 lines
blenloader/
intern/
4 lines
15 lines
bmesh/
intern/
8 lines
1 line
7 lines
49 lines
collada/
2 lines
8 lines
depsgraph/
3 lines
8 lines
intern/
builder/
2 lines
2 lines
8 lines
3 lines
20 lines
4 lines
6 lines
13 lines
92 lines
12 lines
node/
4 lines
4 lines
editors/
armature/
2 lines
include/
9 lines
mesh/
5 lines
2 lines
8 lines
2 lines
10 lines
14 lines
object/
8 lines
8 lines
8 lines
8 lines
2 lines
6 lines
physics/
4 lines
12 lines
render/
8 lines
sculpt_paint/
14 lines
9 lines
6 lines
8 lines
8 lines
space_view3d/
21 lines
8 lines
gpencil_modifiers/
intern/
2 lines
makesdna/
13 lines
5 lines
7 lines
makesrna/
intern/
8 lines
modifiers/
intern/
8 lines
14 lines
12 lines
9 lines
15 lines
9 lines
9 lines
16 lines
13 lines
15 lines
10 lines
4 lines
10 lines
16 lines
9 lines
11 lines
9 lines
4 lines
11 lines
4 lines
11 lines
15 lines
8 lines
7 lines
21 lines
10 lines
7 lines
8 lines
9 lines
9 lines
2 lines
6 lines
2 lines
8 lines
10 lines
14 lines
16 lines
13 lines
12 lines
12 lines
12 lines
14 lines
python/
bmesh/
12 lines
mathutils/
12 lines
render/
intern/
source/
9 lines
windowmanager/
intern/
7 lines

Diff 14039

View Options

source/blender/alembic/intern/abc_hair.cc

View Options

source/blender/alembic/intern/abc_mesh.cc

View Options

source/blender/alembic/intern/abc_points.cc

View Options

source/blender/blenkernel/BKE_DerivedMesh.h

View Options

source/blender/blenkernel/BKE_cdderivedmesh.h

View Options

source/blender/blenkernel/BKE_customdata.h

View Options

source/blender/blenkernel/BKE_data_transfer.h

View Options

source/blender/blenkernel/BKE_editmesh.h

View Options

source/blender/blenkernel/BKE_mesh.h

View Options

source/blender/blenkernel/BKE_mesh_runtime.h

View Options

source/blender/blenkernel/BKE_modifier.h

View Options

source/blender/blenkernel/BKE_particle.h

View Options

source/blender/blenkernel/intern/DerivedMesh.c

View Options

source/blender/blenkernel/intern/cdderivedmesh.c

View Options

source/blender/blenkernel/intern/crazyspace.c

View Options

source/blender/blenkernel/intern/customdata.c

View Options

source/blender/blenkernel/intern/data_transfer.c

View Options

source/blender/blenkernel/intern/editderivedmesh.c

View Options

source/blender/blenkernel/intern/fluidsim.c

View Options

source/blender/blenkernel/intern/mesh.c

View Options

source/blender/blenkernel/intern/mesh_convert.c

View Options

source/blender/blenkernel/intern/mesh_validate.c

View Options

source/blender/blenkernel/intern/modifier.c

View Options

source/blender/blenkernel/intern/multires.c

View Options

source/blender/blenkernel/intern/multires_reshape.c

View Options

source/blender/blenkernel/intern/object_update.c

View Options

source/blender/blenkernel/intern/paint.c

View Options

source/blender/blenkernel/intern/particle.c

View Options

source/blender/blenkernel/intern/pbvh.c

View Options

source/blender/blenkernel/intern/subdiv_foreach.c

View Options

source/blender/blenkernel/intern/subdiv_mesh.c

View Options

source/blender/blenloader/intern/readfile.c

View Options

source/blender/blenloader/intern/writefile.c

View Options

source/blender/bmesh/intern/bmesh_construct.c

View Options

source/blender/bmesh/intern/bmesh_core.c

View Options

source/blender/bmesh/intern/bmesh_mesh_conv.h

View Options

source/blender/bmesh/intern/bmesh_mesh_conv.c

View Options

source/blender/collada/MeshImporter.cpp

View Options

source/blender/collada/collada_utils.cpp

View Options

source/blender/depsgraph/DEG_depsgraph_build.h

Loading...
View Options

source/blender/depsgraph/DEG_depsgraph_query.h

View Options

source/blender/depsgraph/intern/builder/deg_builder.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes.h

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.h

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_relations_rig.cc

View Options

source/blender/depsgraph/intern/depsgraph_build.cc

View Options

source/blender/depsgraph/intern/depsgraph_query.cc

Loading...
View Options

source/blender/depsgraph/intern/depsgraph_type.h

Loading...
View Options

source/blender/depsgraph/intern/depsgraph_type.cc

Loading...
View Options

source/blender/depsgraph/intern/node/deg_node_id.h

Loading...
View Options

source/blender/depsgraph/intern/node/deg_node_id.cc

View Options

source/blender/editors/armature/armature_skinning.c

View Options

source/blender/editors/include/ED_view3d.h

View Options

source/blender/editors/mesh/editmesh_add.c

View Options

source/blender/editors/mesh/editmesh_knife_project.c

View Options

source/blender/editors/mesh/editmesh_tools.c

View Options

source/blender/editors/mesh/editmesh_undo.c

View Options

source/blender/editors/mesh/mesh_data.c

View Options

source/blender/editors/mesh/meshtools.c

View Options

source/blender/editors/object/object_add.c

View Options

source/blender/editors/object/object_bake.c

View Options

source/blender/editors/object/object_data_transfer.c

View Options

source/blender/editors/object/object_modifier.c

View Options

source/blender/editors/object/object_relations.c

View Options

source/blender/editors/object/object_vgroup.c

View Options

source/blender/editors/physics/particle_edit.c

View Options

source/blender/editors/physics/particle_object.c

View Options

source/blender/editors/render/render_opengl.c

View Options

source/blender/editors/sculpt_paint/paint_image_proj.c

View Options

source/blender/editors/sculpt_paint/paint_vertex_proj.c

View Options

source/blender/editors/sculpt_paint/paint_vertex_weight_ops.c

View Options

source/blender/editors/sculpt_paint/sculpt.c

View Options

source/blender/editors/sculpt_paint/sculpt_undo.c

View Options

source/blender/editors/space_view3d/view3d_draw_legacy.c

View Options

source/blender/editors/space_view3d/view3d_iterators.c

View Options

source/blender/gpencil_modifiers/intern/MOD_gpencilsmooth.c

View Options

source/blender/makesdna/DNA_customdata_types.h

View Options

source/blender/makesdna/DNA_object_types.h

View Options

source/blender/makesdna/DNA_scene_types.h

View Options

source/blender/makesrna/intern/rna_modifier.c

View Options

source/blender/modifiers/intern/MOD_armature.c

View Options

source/blender/modifiers/intern/MOD_bevel.c

View Options

source/blender/modifiers/intern/MOD_boolean.c

View Options

source/blender/modifiers/intern/MOD_cast.c

View Options

source/blender/modifiers/intern/MOD_cloth.c

View Options

source/blender/modifiers/intern/MOD_correctivesmooth.c

View Options

source/blender/modifiers/intern/MOD_curve.c

View Options

source/blender/modifiers/intern/MOD_datatransfer.c

View Options

source/blender/modifiers/intern/MOD_decimate.c

View Options

source/blender/modifiers/intern/MOD_displace.c

View Options

source/blender/modifiers/intern/MOD_dynamicpaint.c

View Options

source/blender/modifiers/intern/MOD_edgesplit.c

View Options

source/blender/modifiers/intern/MOD_explode.c

View Options

source/blender/modifiers/intern/MOD_hook.c

View Options

source/blender/modifiers/intern/MOD_laplaciandeform.c

View Options

source/blender/modifiers/intern/MOD_laplaciansmooth.c

View Options

source/blender/modifiers/intern/MOD_lattice.c

View Options

source/blender/modifiers/intern/MOD_mask.c

View Options

source/blender/modifiers/intern/MOD_meshdeform.c

View Options

source/blender/modifiers/intern/MOD_mirror.c

View Options

source/blender/modifiers/intern/MOD_normal_edit.c

View Options

source/blender/modifiers/intern/MOD_ocean.c

View Options

source/blender/modifiers/intern/MOD_particleinstance.c

View Options

source/blender/modifiers/intern/MOD_particlesystem.c

View Options

source/blender/modifiers/intern/MOD_shrinkwrap.c

View Options

source/blender/modifiers/intern/MOD_simpledeform.c

View Options

source/blender/modifiers/intern/MOD_skin.c

View Options

source/blender/modifiers/intern/MOD_smoke.c

View Options

source/blender/modifiers/intern/MOD_smooth.c

View Options

source/blender/modifiers/intern/MOD_solidify.c

View Options

source/blender/modifiers/intern/MOD_surfacedeform.c

View Options

source/blender/modifiers/intern/MOD_triangulate.c

View Options

source/blender/modifiers/intern/MOD_util.c

View Options

source/blender/modifiers/intern/MOD_uvproject.c

View Options

source/blender/modifiers/intern/MOD_uvwarp.c

View Options

source/blender/modifiers/intern/MOD_warp.c

View Options

source/blender/modifiers/intern/MOD_wave.c

View Options

source/blender/modifiers/intern/MOD_weighted_normal.c

View Options

source/blender/modifiers/intern/MOD_weightvgedit.c

View Options

source/blender/modifiers/intern/MOD_weightvgmix.c

View Options

source/blender/modifiers/intern/MOD_weightvgproximity.c

View Options

source/blender/modifiers/intern/MOD_wireframe.c

View Options

source/blender/python/bmesh/bmesh_py_types.c

View Options

source/blender/python/mathutils/mathutils_bvhtree.c

View Options

source/blender/render/intern/source/pointdensity.c

View Options

source/blender/windowmanager/intern/wm_event_system.c