Cleanup: better names and comments for library ID linking code.
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Feb 26 2019, 8:25 PM.

Details

Reviewers

Commits

rBS3ad2d6caef74: Cleanup: better names and comments for library ID linking code.
rB3ad2d6caef74: Cleanup: better names and comments for library ID linking code.

Summary

I'm working on a bugfix in this area, and it took me quite a while to
understand the logic. So I added a bunch of comments, renamed a few
things and split off a few smaller functions.

@Bastien Montagne (mont29), just wanted to check that you are ok with these name changes
since this is not my area.

Diff Detail

Repository: rB Blender

Event Timeline

Brecht Van Lommel (brecht) created this revision.Feb 26 2019, 8:25 PM

Harbormaster completed remote builds in B3011: Diff 13878.Feb 26 2019, 8:25 PM

Brecht Van Lommel (brecht) added a child revision: D4416: Fix viewlayer hide/exclude settings getting lost for linked collections..Feb 26 2019, 8:41 PM

Besides picky details noted about some comments below, patch LGTM (did not check in detail the code changes, but afaics this is mostly moving around some blocks, general logic remains unchanged).

source/blender/blenloader/intern/readfile.c
9524–9530	That’s kind of doublon/extending previous comment (the one just after the case: ), they could both be merged?
11494–11495	Shift-F1 does not exist anymore by default, link/append have no more shortcuts...