Fix T62053: Composite rendering more images than needed
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 1 2019, 11:53 AM.

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T62053: Composite rendering more images than needed

Commits

rBS9f77c202868b: Fix T62053: Composite rendering more images than needed
rB9f77c202868b: Fix T62053: Composite rendering more images than needed

Diff Detail

Repository

rB Blender

Branch

T62053 (branched from master)

Build Status

Buildable 3025
Build 3025: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 1 2019, 11:53 AM

Harbormaster completed remote builds in B3025: Diff 13942.Mar 1 2019, 11:53 AM

Harbormaster completed remote builds in B3025: Diff 13942.

note: behaviour [2.7 --> 2.8] changed in:
rB56d6d13b0debc866c8638eab3d4626e0c038e31c
rB3801736b891ea0a1ca3c9a8927a44d38527fcefc

Thanks for finding that.

LIB_TAG_DOIT is no cleared before use while the comment in DNA_ID.h says that it should be.

I suggest to use BLI_gset_ptr_new with scene pointers instead since this kind of tagging is not ideal for thread safety or COW.

This revision now requires changes to proceed.Mar 1 2019, 12:09 PM

replace id tagging with tracking already rendered scenes in a GSet

Harbormaster completed remote builds in B3026: Diff 13943.Mar 1 2019, 12:39 PM

Vitor Balbio (vitorbalbio) awarded a token.Mar 1 2019, 12:43 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 1 2019, 12:44 PM

This revision is now accepted and ready to land.Mar 1 2019, 12:44 PM

Closed by commit rB9f77c202868b: Fix T62053: Composite rendering more images than needed (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 1 2019, 12:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

render/

intern/

source/

pipeline.c

18 lines

Diff 13942

View Options

source/blender/render/intern/source/pipeline.c

Fix T62053: Composite rendering more images than neededClosedPublicActions