Page MenuHome
Differential D4433

Fix crash with highpoly curves on some AMD cards.
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Mar 1 2019, 3:28 PM.

Details

Reviewers
Clément Foucault (fclem)
Commits
rBSfa5950d87820: Fix crash with wireframe on highpoly curves on some AMD gpus.
rBfa5950d87820: Fix crash with wireframe on highpoly curves on some AMD gpus.
Summary

I'm not sure the reason for the crash, this is really something weird.
The solution was to imitate the same scheme of vbos used in the Mesh (which does not crash).
Unfortunately for this you need to create a vbo filled with a single value.

This fix the T62030.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 3029
Build 3029: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Mar 1 2019, 3:28 PM
Harbormaster completed remote builds in B3029: Diff 13947.Mar 1 2019, 3:28 PM
Clément Foucault (fclem) accepted this revision.Mar 1 2019, 3:32 PM
This revision is now accepted and ready to land.Mar 1 2019, 3:32 PM
Closed by commit rBfa5950d87820: Fix crash with wireframe on highpoly curves on some AMD gpus. (authored by Germano Cavalcante (mano-wii)). · Explain WhyMar 1 2019, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
intern/
3 lines
8 lines
30 lines
17 lines

Diff 13947

View Options

source/blender/draw/intern/draw_cache_impl.h

Loading...
View Options

source/blender/draw/intern/draw_cache_impl_curve.c

Loading...
View Options

source/blender/draw/intern/draw_cache_impl_displist.c

Loading...
View Options

source/blender/draw/intern/draw_cache_impl_metaball.c

Loading...