Fix T62190: Image editor pixel values are hidden by header at the bottom
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 5 2019, 10:53 AM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Maniphest Tasks

T62190: Image editor pixel values are hidden by header at the bottom.

Commits

rBS6c513dc3e47d: Fix T62190: Image editor pixel values are hidden by header at the bottom
rB6c513dc3e47d: Fix T62190: Image editor pixel values are hidden by header at the bottom

Summary

since header regions can possibly overlap, accommodate by getting main
regions visible rect first.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 5 2019, 10:53 AM

Harbormaster completed remote builds in B3048: Diff 13997.Mar 5 2019, 10:53 AM

Harbormaster completed remote builds in B3048: Diff 13997.

From reading and testing seems good.
But i'm not sure why or how this is different from 2.7.

@Sergey Sharybin (sergey): Afaics, 2.7 just didnt have overlapping (possibly transparent) header in Image Editor? [thats why main region rect extends are different, right?]

2.8 has region overlap enabled by default, which also works in the image editor.

This revision is now accepted and ready to land.Mar 5 2019, 11:10 AM

Closed by commit rB6c513dc3e47d: Fix T62190: Image editor pixel values are hidden by header at the bottom (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 5 2019, 11:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_image/

image_draw.c

11 lines

Diff 13999

View Options

source/blender/editors/space_image/image_draw.c

Fix T62190: Image editor pixel values are hidden by header at the bottomClosedPublicActions