Page MenuHome
Differential D4452

Fix T62112: wrong curve face count
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 5 2019, 5:29 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Maniphest Tasks
T62112: Blender miscounts object faces
Commits
rBS5e8e3c00f2aa: Fix T62112: wrong curve face count
rB5e8e3c00f2aa: Fix T62112: wrong curve face count
Summary

A similar problem probably exists in the other cases, but I still
have to figure out what DL_INDEX3 etc. actually means.

Diff Detail

Repository
rB Blender
Branch
wrong-face-count (branched from master)
Build Status
Buildable 3054
Build 3054: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 5 2019, 5:29 PM
Harbormaster completed remote builds in B3054: Diff 14007.Mar 5 2019, 5:29 PM
Jacques Lucke (JacquesLucke) added a task: T62112: Blender miscounts object faces.Mar 5 2019, 5:29 PM
Brecht Van Lommel (brecht) accepted this revision.Mar 5 2019, 7:03 PM

Looks good to me.

DL_INDEX3 and DL_INDEX4 are just an array of tesselated triangles and quads respectively, don't need to take into account cyclic stuff. DL_POLY and DL_SEGM already match logic in BKE_mesh_nurbs_displist_to_mdata.

This revision is now accepted and ready to land.Mar 5 2019, 7:03 PM
Closed by commit rB5e8e3c00f2aa: Fix T62112: wrong curve face count (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMar 5 2019, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
6 lines

Diff 14007

View Options

source/blender/blenkernel/intern/displist.c

Loading...