Details

Reviewers

Group Reviewers

Commits

rCb6bc991469dd: Cycles/OpenCL: Reduce How Often Kernel Recompilations Are Needed
rBS298dabc79b9a: Cycles/OpenCL: Reduce How Often Kernel Recompilations Are Needed
rB298dabc79b9a: Cycles/OpenCL: Reduce How Often Kernel Recompilations Are Needed

Summary

This patch will reduce the number of times that we need to
recompile the kernels. It does this by enabling selected features
by default. So when the user needs them that the kernels are
already available.

Other features are enabled by default for background and foreground
rendering. When in background rendering the user wants the best
render performance. When in foreground rendering the user wants
the least amount of recompilations.

Enabling volumetrics or subdivision evaluation will still trigger
a recompilation during foreground rendering.

See attachment for detailed information about the kernel
recompilations

201903 program variations - D4485.pdf69 KBDownload

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 8 2019, 3:54 PM

Harbormaster completed remote builds in B3088: Diff 14079.Mar 8 2019, 3:54 PM

Code cleanup

Harbormaster completed remote builds in B3089: Diff 14080.Mar 8 2019, 4:00 PM

Jeroen Bakker (jbakker) added reviewers: Cycles, Brecht Van Lommel (brecht).Mar 8 2019, 4:01 PM

Jeroen Bakker (jbakker) added a project: Cycles.

Code cleanup

Harbormaster completed remote builds in B3090: Diff 14083.Mar 8 2019, 4:34 PM

research how many kernel (variations) we currently have before and after this patch
change the features for baking to have less variations.

Code cleanup
D4485: Reduction of foreground kernels recompilation

Harbormaster completed remote builds in B3107: Diff 14127.Mar 12 2019, 1:37 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Mar 12 2019, 1:38 PM

Looks good to me.

The title of this revision is a bit misleading, would instead use Cycles/OpenCL: reduce how often kernel recompilations are needed.

Also please check the commit log guidelines again, do not start with a task number but with category like Cycles/OpenCL.
https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

This revision is now accepted and ready to land.Mar 12 2019, 1:49 PM