Page MenuHome
Differential D4486

Fix T62359: Flip colors for Fill Tool missing
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 8 2019, 7:36 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Julien Kaspar (JulienKaspar)
Maniphest Tasks
T62359: Flip colors for Fill Tool missing
Commits
rBS4302342287b5: Fix T62359: Flip colors for Fill Tool missing
rB4302342287b5: Fix T62359: Flip colors for Fill Tool missing

Diff Detail

Repository
rB Blender
Branch
T62359 (branched from master)
Build Status
Buildable 3092
Build 3092: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 8 2019, 7:36 PM
Harbormaster completed remote builds in B3092: Diff 14088.Mar 8 2019, 7:36 PM
Julien Kaspar (JulienKaspar) added a comment.Mar 11 2019, 11:43 AM

@Philipp Oeser (lichtwerk) Sorry I can't use the Diff for some reason. Can you send me a build so I can test it?

Philipp Oeser (lichtwerk) added a comment.Mar 11 2019, 12:29 PM

@Julien Kaspar (JulienKaspar) : are you using arc?
arc patch D4486 is working here... otherwise maybe I can kick the buildbot for experimental-build branch...

Brecht Van Lommel (brecht) accepted this revision.Mar 11 2019, 1:51 PM
This revision is now accepted and ready to land.Mar 11 2019, 1:51 PM
Julien Kaspar (JulienKaspar) added a comment.Mar 11 2019, 1:57 PM

@Philipp Oeser (lichtwerk) I don't think so. I am doing it through the linux terminal based on how some developers at the studio walked me through it. I don't know what arc is ...

Closed by commit rB4302342287b5: Fix T62359: Flip colors for Fill Tool missing (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 11 2019, 2:41 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a comment.Mar 11 2019, 2:45 PM

@Julien Kaspar (JulienKaspar) : committed now, please check. reg. Arc there is a small section in our wiki https://wiki.blender.org/wiki/Tools/CodeReview [it is just a quick tool to submit and apply patches from phabricator/developer.blender.org]

Julien Kaspar (JulienKaspar) added a comment.Mar 11 2019, 3:33 PM

@Philipp Oeser (lichtwerk) I will look into arc. Thanks for the commit. It works just as expected :)

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
10 lines
11 lines
1 line
5 lines

Diff 14088

View Options

source/blender/editors/sculpt_paint/paint_image.c

Loading...
View Options

source/blender/editors/sculpt_paint/paint_image_proj.c

Loading...
View Options

source/blender/editors/sculpt_paint/paint_intern.h

Loading...
View Options

source/blender/editors/sculpt_paint/paint_stroke.c

Loading...