Select similar operator for curves
AbandonedPublic
Actions

Authored by Julian Eisel (Severin) on Apr 5 2014, 3:54 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
Walid Shouman (walid)

Maniphest Tasks

T37872: Select Grouped for Curves

Diff Detail

Event Timeline

Walid Shouman (walid) added inline comments.Apr 5 2014, 4:00 AM

source/blender/editors/curve/editcurve.c
6274	every usage of select_bpoint() or select_beztriple() gives me the following warning! /home/walid3/Programmes/blender_git/master/source/blender/editors/curve/editcurve.c:6274: warning: the address of 'select' will always evaluate as 'true' [-Waddress] select_bpoint(bp, select, SELECT, VISIBLE); ^

Should we really have a threshold or compare is just enough?

Note: there are always an instance of code for bezier and another for pboints, that could be eliminated at the cost of introducing checks in the while loops :/, if there's a better practice to follow that would be great.

Directly using the SELECT flag (shutting down the warnings)

Change the operator type from Size to Weight
Unify the align behavior in Beztriple and BPoint

Walid Shouman (walid) added inline comments.Apr 6 2014, 11:40 AM

source/blender/editors/curve/editcurve.c
5916	this could be taken to another deeper level to be recognized over objects/metaballs/armature ... if that's desired, where to move it?

is it bettter to move both ED_curve_direction_bezt() and ED_curve_direction_bp() to curve.c?

needs key shortcut - WM_keymap_add_item(keymap, "CURVE_OT_select_similar", GKEY, KM_PRESS, KM_SHIFT, 0);
needs menu item
only compares to points within the spline, I think it should compare with all points in the curve.
comparing the Tilt fails, I added a path and tried to select similar tilt.