Fix T58668: Misaligned text when editing multiple values
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 12 2019, 2:22 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Maniphest Tasks

T58668: Selecting/editing multiple values at once in properties panel causes misalignment

Commits

rBS17e0565cc574: Fix T58668: Misaligned text when editing multiple values
rB17e0565cc574: Fix T58668: Misaligned text when editing multiple values

Summary

An alternative fix could be to just always apply the
text padding on the left and right when the text is drawn.
Not sure if there are cases when we don't want the padding.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 12 2019, 2:22 PM

Harbormaster completed remote builds in B3111: Diff 14132.Mar 12 2019, 2:22 PM

Jacques Lucke (JacquesLucke) added a task: T58668: Selecting/editing multiple values at once in properties panel causes misalignment.Mar 12 2019, 2:22 PM

This fix by itself seems fine, not sure what the consequences are of always adding the padding.

This revision is now accepted and ready to land.Mar 13 2019, 2:17 PM

Closed by commit rB17e0565cc574: Fix T58668: Misaligned text when editing multiple values (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMar 13 2019, 4:27 PM

This revision was automatically updated to reflect the committed changes.

Yevgeny Makarov (jenkm) mentioned this in D6925: UI: Fix text padding for labels without an icon.Mar 2 2020, 2:03 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

interface/

interface_widgets.c

18 lines

Diff 14157

View Options

source/blender/editors/interface/interface_widgets.c

Fix T58668: Misaligned text when editing multiple valuesClosedPublicActions