Fix T62114: Wireframe mode selection: selects backside objects when clicking frontside object in 3d-window
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Mar 12 2019, 4:55 PM.

Details

Reviewers

Germano Cavalcante (mano-wii)
Clément Foucault (fclem)

Commits

rBScc74020b5ac7: Fix T62114: Wireframe mode selection: selects backside objects when clicking…
rBcc74020b5ac7: Fix T62114: Wireframe mode selection: selects backside objects when clicking…

Summary

Now the depth order of objects when trying to select them is only used when not in X-ray mode.
Before, this was only the case in wireframe mode regardless of X-ray settings.

I've also unified the usage of V3D_XRAY and XRAY_FLAG as they were basically copies of each other.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) created this revision.Mar 12 2019, 4:55 PM

Sebastian Parborg (zeddb) mentioned this in T62114: Wireframe mode selection: selects backside objects when clicking frontside object in 3d-window.

Sebastian Parborg (zeddb) mentioned this in T63341: Xray mode makes some shading popover options grayed out despite them working.Apr 7 2019, 8:49 PM

Clément Foucault (fclem) accepted this revision.Apr 7 2019, 10:22 PM

This revision is now accepted and ready to land.Apr 7 2019, 10:22 PM

Closed by commit rBcc74020b5ac7: Fix T62114: Wireframe mode selection: selects backside objects when clicking… (authored by Sebastian Parborg (zeddb)). · Explain WhyApr 9 2019, 12:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

gpencil/

gpencil_engine.c

2 lines

workbench/

workbench_forward.c

1 line

workbench_render.c

2 lines

intern/

DRW_render.h

4 lines

modes/

edit_mesh_mode.c

2 lines

object_mode.c

3 lines

overlay_mode.c

2 lines

editors/

armature/

armature_select.c

4 lines

include/

ED_view3d.h

8 lines

mesh/

editmesh_select.c

12 lines

physics/

particle_edit.c

4 lines

space_view3d/

view3d_select.c

14 lines

view3d_view.c

9 lines

transform/

transform.c

4 lines

transform_snap_object.c

6 lines

Diff 14139

View Options

source/blender/draw/engines/gpencil/gpencil_engine.c

View Options

source/blender/draw/engines/workbench/workbench_forward.c

View Options

source/blender/draw/engines/workbench/workbench_render.c

View Options

source/blender/draw/intern/DRW_render.h

View Options

source/blender/draw/modes/edit_mesh_mode.c

View Options

source/blender/draw/modes/object_mode.c

View Options

source/blender/draw/modes/overlay_mode.c

View Options

source/blender/editors/armature/armature_select.c

View Options

source/blender/editors/include/ED_view3d.h

View Options

source/blender/editors/mesh/editmesh_select.c

View Options

source/blender/editors/physics/particle_edit.c

View Options

source/blender/editors/space_view3d/view3d_select.c

View Options

source/blender/editors/space_view3d/view3d_view.c

View Options

source/blender/editors/transform/transform.c

View Options

source/blender/editors/transform/transform_snap_object.c

Fix T62114: Wireframe mode selection: selects backside objects when clicking frontside object in 3d-windowClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14139

source/blender/draw/engines/gpencil/gpencil_engine.c

source/blender/draw/engines/workbench/workbench_forward.c

source/blender/draw/engines/workbench/workbench_render.c

source/blender/draw/intern/DRW_render.h

source/blender/draw/modes/edit_mesh_mode.c

source/blender/draw/modes/object_mode.c

source/blender/draw/modes/overlay_mode.c

source/blender/editors/armature/armature_select.c

source/blender/editors/include/ED_view3d.h

source/blender/editors/mesh/editmesh_select.c

source/blender/editors/physics/particle_edit.c

source/blender/editors/space_view3d/view3d_select.c

source/blender/editors/space_view3d/view3d_view.c

source/blender/editors/transform/transform.c

source/blender/editors/transform/transform_snap_object.c

Fix T62114: Wireframe mode selection: selects backside objects when clicking frontside object in 3d-window
ClosedPublic
Actions

Revision Contents
Changeset List