Fix T62601: parenting to curve (follow path) causes offset
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 15 2019, 4:32 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Maniphest Tasks

T62601: 2.8 Follow Path bug

Commits

rBS9ad9d38786c5: Fix T62601: parenting to curve (follow path) causes offset
rB9ad9d38786c5: Fix T62601: parenting to curve (follow path) causes offset

Summary

Similar to T60623 / rB2894e75121d7
issue (when parenting with 'Follow Curve') is that the curves
CU_FOLLOW flag is set on the original, but not the
evaluated curve (yet), leading to misbehaviour in 'ob_parcurve()'.
Setting this on both now.

Diff Detail

Repository

rB Blender

Branch

T62601 (branched from master)

Build Status

Buildable 3133
Build 3133: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 15 2019, 4:32 PM

Harbormaster completed remote builds in B3133: Diff 14198.Mar 15 2019, 4:32 PM

note that you do get a jumping if you parent on a different frame than frame zero.
(transforms will match if you go back to frame zero then)

This is correct I guess (basis for path animation was frame zero in 2.79 as well -- 2.79 was just missing an update here...)

Sergey Sharybin (sergey) accepted this revision.Mar 15 2019, 6:04 PM

This revision is now accepted and ready to land.Mar 15 2019, 6:04 PM

Closed by commit rB9ad9d38786c5: Fix T62601: parenting to curve (follow path) causes offset (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 15 2019, 6:52 PM

This revision was automatically updated to reflect the committed changes.

楊景貴 (issac) added a subscriber: 楊景貴 (issac).Mar 16 2019, 4:35 PM

This comment was removed by 楊景貴 (issac).

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

object/

object_relations.c

4 lines

Diff 14198

View Options

source/blender/editors/object/object_relations.c

Fix T62601: parenting to curve (follow path) causes offsetClosedPublicActions