Page MenuHome
Differential D4537

Remove node_insert_link_default from ShaderNodeCustomGroup and CompositorNodeCustomGroup
ClosedPublic
Actions

Authored by Miguel Porces (cmporces) on Mar 18 2019, 6:41 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T62670: ShaderNodeCustomGroup insert_link is not listening to inserts
Commits
rBS1b06e3378a75: Fix T62670: insert_link() method not working for ShaderNodeCustomGroup.
rB1b06e3378a75: Fix T62670: insert_link() method not working for ShaderNodeCustomGroup.
Summary

Should fix T62670

Diff Detail

Repository
rB Blender

Event Timeline

Miguel Porces (cmporces) created this revision.Mar 18 2019, 6:41 AM
Miguel Porces (cmporces) added a reviewer: Brecht Van Lommel (brecht).Mar 18 2019, 6:43 AM
Brecht Van Lommel (brecht) accepted this revision.Mar 18 2019, 11:34 AM

I think we should still use the default implementation if none is provided, will make that change and commit.

This revision is now accepted and ready to land.Mar 18 2019, 11:34 AM
Closed by commit rB1b06e3378a75: Fix T62670: insert_link() method not working for ShaderNodeCustomGroup. (authored by Miguel Porces (cmporces), committed by Brecht Van Lommel (brecht)). · Explain WhyMar 18 2019, 11:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
composite/
nodes/
12 lines
shader/
nodes/
13 lines

Diff 14239

View Options

source/blender/nodes/composite/nodes/node_composite_common.c

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_common.c

Loading...