Paths

Table of Contentst

Differential D4541

Subdiv: Enable topology cache in edit mode
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Mar 18 2019, 4:01 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T61746: Slow edit mode

Commits

rBS8fb0b9aebbd4: Subdiv: Enable topology cache in edit mode
rB8fb0b9aebbd4: Subdiv: Enable topology cache in edit mode

Summary

The general idea of this change is to have a runtime data pointer
in the ModifierData, so it can be preserved through copy-on-write
updates by the dependency graph.

This is where subdivision surface modifier can store its topology
cache, so it is not getting trashed on every copy-on-write which
is happening when moving a vertex.

Similar mechanism should be used by multiresolution, dynamic paint
and some other modifiers which cache evaluated data.

This fixes T61746.
Thing to keep in mind, that there are more reports about slow
subdivision surface in the tracker, but that boils down to the
fact that those have a lot of extraordinary vertices, and hence
a lot slower to evaluated topology.

Diff Detail

Repository

Branch

topology_cache_edit_mode (branched from master)

Build Status

Buildable 3165
Build 3165: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) created this revision.Mar 18 2019, 4:01 PM

Harbormaster completed remote builds in B3163: Diff 14249.Mar 18 2019, 4:01 PM

Harbormaster completed remote builds in B3163: Diff 14249.

Brecht Van Lommel (brecht) requested changes to this revision.Mar 18 2019, 4:13 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc
876–879	Shouldn't it be like this? if (modifier_data == other.modifier_data) { return static_cast<int>(type) < static_cast<int>(other.type); } return false;
946–951	Can we do this only for objects with `modifier_data->runtime != NULL`?

This revision now requires changes to proceed.Mar 18 2019, 4:13 PM

Addressed bug found by Brecht.

Harbormaster completed remote builds in B3165: Diff 14251.Mar 18 2019, 4:25 PM

Addressed another point from Brecht.
Missed that in the first round of update.

Harbormaster completed remote builds in B3167: Diff 14253.Mar 18 2019, 4:58 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 18 2019, 5:09 PM

This revision is now accepted and ready to land.Mar 18 2019, 5:09 PM

Closed by commit rB8fb0b9aebbd4: Subdiv: Enable topology cache in edit mode (authored by Sergey Sharybin (sergey)). · Explain WhyMar 18 2019, 5:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

14 lines

blenloader/

intern/

2 lines

depsgraph/

intern/

depsgraph_type.h

6 lines

eval/

deg_eval_copy_on_write.cc

236 lines

makesdna/

DNA_modifier_types.h

4 lines

modifiers/

intern/

1 line

1 line

1 line

1 line

1 line

1 line

1 line

MOD_collision.c

1 line

MOD_correctivesmooth.c

1 line

1 line

MOD_datatransfer.c

1 line

1 line

1 line

MOD_dynamicpaint.c

1 line

MOD_edgesplit.c

1 line

1 line

1 line

1 line

MOD_laplaciandeform.c

1 line

MOD_laplaciansmooth.c

1 line

1 line

1 line

MOD_meshcache.c

1 line

MOD_meshdeform.c

1 line

MOD_meshsequencecache.c

1 line

1 line

1 line

1 line

MOD_normal_edit.c

1 line

1 line

MOD_particleinstance.c

1 line

MOD_particlesystem.c

1 line

1 line

1 line

1 line

MOD_shrinkwrap.c

1 line

MOD_simpledeform.c

1 line

1 line

1 line

1 line

1 line

1 line

45 lines

1 line

MOD_surfacedeform.c

1 line

MOD_triangulate.c

1 line

MOD_uvproject.c

1 line

1 line

1 line

1 line

MOD_weighted_normal.c

1 line

MOD_weightvgedit.c

1 line

MOD_weightvgmix.c

1 line

MOD_weightvgproximity.c

1 line

MOD_wireframe.c

1 line

Diff 14251

source/blender/blenkernel/BKE_modifier.h

Loading...

source/blender/blenloader/intern/readfile.c

Loading...

source/blender/depsgraph/intern/depsgraph_type.h

Loading...

source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc

Loading...

source/blender/makesdna/DNA_modifier_types.h

Loading...

source/blender/modifiers/intern/MOD_armature.c

Loading...

source/blender/modifiers/intern/MOD_array.c

Loading...

source/blender/modifiers/intern/MOD_bevel.c

Loading...

source/blender/modifiers/intern/MOD_boolean.c

Loading...

source/blender/modifiers/intern/MOD_build.c

Loading...

source/blender/modifiers/intern/MOD_cast.c

Loading...

source/blender/modifiers/intern/MOD_cloth.c

Loading...

source/blender/modifiers/intern/MOD_collision.c

Loading...

source/blender/modifiers/intern/MOD_correctivesmooth.c

Loading...

source/blender/modifiers/intern/MOD_curve.c

Loading...

source/blender/modifiers/intern/MOD_datatransfer.c

Loading...

source/blender/modifiers/intern/MOD_decimate.c

Loading...

source/blender/modifiers/intern/MOD_displace.c

Loading...

source/blender/modifiers/intern/MOD_dynamicpaint.c

Loading...

source/blender/modifiers/intern/MOD_edgesplit.c

Loading...

source/blender/modifiers/intern/MOD_explode.c

Loading...

source/blender/modifiers/intern/MOD_fluidsim.c

Loading...

source/blender/modifiers/intern/MOD_hook.c

Loading...

source/blender/modifiers/intern/MOD_laplaciandeform.c

Loading...

source/blender/modifiers/intern/MOD_laplaciansmooth.c

Loading...

source/blender/modifiers/intern/MOD_lattice.c

Loading...

source/blender/modifiers/intern/MOD_mask.c

Loading...

source/blender/modifiers/intern/MOD_meshcache.c

Loading...

source/blender/modifiers/intern/MOD_meshdeform.c

Loading...

source/blender/modifiers/intern/MOD_meshsequencecache.c

Loading...

source/blender/modifiers/intern/MOD_mirror.c

Loading...

source/blender/modifiers/intern/MOD_multires.c

Loading...

source/blender/modifiers/intern/MOD_none.c

Loading...

source/blender/modifiers/intern/MOD_normal_edit.c

Loading...

source/blender/modifiers/intern/MOD_ocean.c

Loading...

source/blender/modifiers/intern/MOD_particleinstance.c

Loading...

source/blender/modifiers/intern/MOD_particlesystem.c

Loading...

source/blender/modifiers/intern/MOD_remesh.c

Loading...

source/blender/modifiers/intern/MOD_screw.c

Loading...

source/blender/modifiers/intern/MOD_shapekey.c

Loading...

source/blender/modifiers/intern/MOD_shrinkwrap.c

Loading...

source/blender/modifiers/intern/MOD_simpledeform.c

Loading...

source/blender/modifiers/intern/MOD_skin.c

Loading...

source/blender/modifiers/intern/MOD_smoke.c

Loading...

source/blender/modifiers/intern/MOD_smooth.c

Loading...

source/blender/modifiers/intern/MOD_softbody.c

Loading...

source/blender/modifiers/intern/MOD_solidify.c

Loading...

source/blender/modifiers/intern/MOD_subsurf.c

Loading...

source/blender/modifiers/intern/MOD_surface.c

Loading...

source/blender/modifiers/intern/MOD_surfacedeform.c

Loading...

source/blender/modifiers/intern/MOD_triangulate.c

Loading...

source/blender/modifiers/intern/MOD_uvproject.c

Loading...

source/blender/modifiers/intern/MOD_uvwarp.c

Loading...

source/blender/modifiers/intern/MOD_warp.c

Loading...

source/blender/modifiers/intern/MOD_wave.c

Loading...

source/blender/modifiers/intern/MOD_weighted_normal.c

Loading...

source/blender/modifiers/intern/MOD_weightvgedit.c

Loading...

source/blender/modifiers/intern/MOD_weightvgmix.c

Loading...

source/blender/modifiers/intern/MOD_weightvgproximity.c

Loading...

source/blender/modifiers/intern/MOD_wireframe.c

Loading...