Page MenuHome

Workbench: Support Odd Number Of AA Samples
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Mar 19 2019, 10:36 AM.

Details

Summary

Workbench render engine did not work when an odd number of AA samples
were used. A user could enter these values by disabling AA or set the
number of AA samples in the Render/Film panel to an odd number.

This commit will not perform TAA passes when AA is disabled.
For supporting the setting of 5 or 11 samples the bitmask was replaced
by an if statement as this was making the odd number not render
correctly.

As extra introduce the jitter samples of 5 and 11 so the images will
be more clean. a jitter sample of 11 used to read outside the allocated
space of the jitter samples.

Fix T60820

Diff Detail

Repository
rB Blender
Branch
T60820 (branched from master)
Build Status
Buildable 3176
Build 3176: arc lint + arc unit

Event Timeline

Harbormaster completed remote builds in B3176: Diff 14279.
source/blender/draw/engines/workbench/workbench_effect_taa.c
241

isn't this just the modulo ? (%)

  • Changed controlflow logic to modulo
Jeroen Bakker (jbakker) marked an inline comment as done.Mar 19 2019, 12:52 PM
This revision is now accepted and ready to land.Mar 19 2019, 1:52 PM
This revision was automatically updated to reflect the committed changes.