Page MenuHome
Differential D4552

Workbench: World Clipping For Specular Transparent
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 19 2019, 3:34 PM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T61023: Workbench shading bugs out when using partially transparent materials,studio lighting and view clipping at the same time.
Summary

When Specular Transparent materials are used the world clipping
did not work on the transparent materials. The reason was that the
accum shaders did not vary on the existance of the clipping planes

This patch will variate the accum shaders when clipping planes are
active.

Fix T61023

Diff Detail

Repository
rB Blender
Branch
T61023 (branched from master)
Build Status
Buildable 3185
Build 3185: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 19 2019, 3:34 PM
Harbormaster completed remote builds in B3185: Diff 14290.Mar 19 2019, 3:34 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Mar 19 2019, 3:34 PM
Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).
Clément Foucault (fclem) accepted this revision.Mar 19 2019, 3:39 PM
This revision is now accepted and ready to land.Mar 19 2019, 3:39 PM
Jeroen Bakker (jbakker) closed this revision.Mar 19 2019, 3:45 PM

Committed by e226460dd35b1439092888f280b00e7993d78f13

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
workbench/
2 lines
2 lines
7 lines
3 lines

Diff 14290

View Options

source/blender/draw/engines/workbench/workbench_deferred.c

Loading...
View Options

source/blender/draw/engines/workbench/workbench_forward.c

Loading...
View Options

source/blender/draw/engines/workbench/workbench_materials.c

Loading...
View Options

source/blender/draw/engines/workbench/workbench_private.h

Loading...