Page MenuHome
Differential D4558

Fix T61670: Copy -> Paste - Pasted elements are not selected
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Mar 20 2019, 2:51 AM.

Details

Reviewers
Bastien Montagne (mont29)
Brecht Van Lommel (brecht)
Commits
rBS0c44b7e177f3: Fix T61670: Copy -> Paste - Pasted elements are not selected
rB0c44b7e177f3: Fix T61670: Copy -> Paste - Pasted elements are not selected
Summary

The first part of this patch is just a way to improve performance a bit
by not calling BKE_scene_object_base_flag_sync_from_base() twice.

The second is the proper fix for the reported issue.

(T61670)

Diff Detail

Repository
rB Blender
Branch
fix-unselected-pasted-objects (branched from master)
Build Status
Buildable 3191
Build 3191: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) created this revision.Mar 20 2019, 2:51 AM
Harbormaster completed remote builds in B3191: Diff 14311.Mar 20 2019, 2:51 AM
Bastien Montagne (mont29) accepted this revision.Mar 20 2019, 10:16 AM

Yes, think that commit is OK in any case, collections instancing should follow FILE_AUTOSELECT just like object instancing does.

This revision is now accepted and ready to land.Mar 20 2019, 10:16 AM
Bastien Montagne (mont29) mentioned this in T61670: Copy -> Paste - Pasted elements are not selected.Mar 20 2019, 10:22 AM
Brecht Van Lommel (brecht) accepted this revision.Mar 20 2019, 11:09 AM
Closed by commit rB0c44b7e177f3: Fix T61670: Copy -> Paste - Pasted elements are not selected (authored by Dalai Felinto (dfelinto)). · Explain WhyMar 20 2019, 11:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
20 lines

Diff 14311

View Options

source/blender/blenloader/intern/readfile.c

Loading...