Fix T62815: wrong camera outline when shift_x is changed
AbandonedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 21 2019, 2:07 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)

Maniphest Tasks

T62815: Camera outline does not represent Lens shifting in X axis correctly

Summary

There seem to be two issues here:

is_stereo3d_view was true even though no stereo was used.
The offset with shift_x seems unnecessary/incorrect.

I've never used stereo rendering in Blender myself,
so I don't know how it should look like.
It feels more correct with this fix.

Diff Detail

Repository

rB Blender

Branch

camera-shift (branched from master)

Build Status

Buildable 3208
Build 3208: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 21 2019, 2:07 PM

Harbormaster completed remote builds in B3208: Diff 14337.Mar 21 2019, 2:08 PM

Jacques Lucke (JacquesLucke) added a task: T62815: Camera outline does not represent Lens shifting in X axis correctly.Mar 21 2019, 2:11 PM

The result looks wrong to me:

As far as I know one view moves and another stays in the center, this looks like something else?

In 2.79 the camera frame did not even show any anaglyph colors or offset, which is probably most useful.

This revision now requires changes to proceed.Mar 22 2019, 6:31 PM

I recognize the reported bug is there, and I will look into fixing it (99% sure I introduced this in d1ef6be4a770.
That said I think this patch is wrong.

Fix committed in master (faecac0b5e1).

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

modes/

object_mode.c

7 lines

Diff 14337

View Options

source/blender/draw/modes/object_mode.c

Fix T62815: wrong camera outline when shift_x is changedAbandonedPublicActions