Page MenuHome

Fix T39627
AbandonedPublic

Authored by Antonis Ryakiotakis (psy-fi) on Apr 7 2014, 8:21 PM.

Details

Summary

HSL sliders jumping. The issue here is that we store HSV in display space.
To correctly account for that, made sure HSV/HSL is now using the displayed
color to compute the values in the sliders. RGB values still show
the property values (linear for linear, gamma corrected for gamma corrected)

We could change the way we store HSV, but we would need to add many more
conversions in the picker code to account for storing it that way.
My fix takes into account the way HSV is stored in HSVCube as well in the code.

Color pickers should help with visible color selection, but since having
HSV be in property display space has been a design choice this will go
through review.

Diff Detail

Branch
HSL_fix

Event Timeline

How do I redo the issue with HSL sliders jumping around?

With complete white the color-wheel jumps around a lot when dragging the mouse over it. but the patch doesnt fix this issue (test when changing material color).

Just enter the values 0.5 0.5 0.5 in HSL, confirm, close the dialog and reopen. The values will have shifted.

Next is try moving the wheel widget while HSL values are displayed. The lightness changes value while it shouldn't. Also lightness slider and value are not in synch in either HSV/HSL (0.5 does not correspond to middle of the bar on the right).

The weird thing is that I can't reproduce the jumping with white color on windows Oo. Will try again on ubuntu too.