Implement Stencil Mask Drawing for Texture Painting
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 21 2019, 3:58 PM.

Details

Reviewers

Maniphest Tasks

T58727: Mask Tool has no working visualization

Commits

rBS177623dd4043: Implement Stencil Mask Drawing for Texture Painting
rB177623dd4043: Implement Stencil Mask Drawing for Texture Painting

Summary

Stencil mask drawing was not implemented yet. This commit will implement this for texture painting.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 21 2019, 3:58 PM

Harbormaster completed remote builds in B3211: Diff 14340.Mar 21 2019, 3:58 PM

Harbormaster completed remote builds in B3211: Diff 14340.

Jeroen Bakker (jbakker) retitled this revision from Initial Drawing of texture paint mask to Initial Drawing of texture paint mask (WIP).Mar 21 2019, 3:58 PM

Clément Foucault (fclem) added a subscriber: Clément Foucault (fclem).Mar 21 2019, 4:19 PM

Clément Foucault (fclem) added inline comments.

source/blender/draw/modes/shaders/paint_texture_frag.glsl
33	mask.rgb = 1.0 - mask.rgb;

Invalidate drawing cache when UV layer is selected for mask

Harbormaster completed remote builds in B3212: Diff 14341.Mar 21 2019, 4:41 PM

Code review comment frag shader

Harbormaster completed remote builds in B3213: Diff 14342.Mar 21 2019, 4:44 PM

Jeroen Bakker (jbakker) marked an inline comment as done.Mar 21 2019, 4:44 PM

Jeroen Bakker (jbakker) retitled this revision from Initial Drawing of texture paint mask (WIP) to Implement Stencil Mask Drawing for Texture Painting.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).

Clément Foucault (fclem) accepted this revision.Mar 21 2019, 6:20 PM

This revision is now accepted and ready to land.Mar 21 2019, 6:20 PM

Closed by commit rB177623dd4043: Implement Stencil Mask Drawing for Texture Painting (authored by Jeroen Bakker (jbakker)). · Explain WhyMar 22 2019, 8:22 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) mentioned this in D4561: TexturePaint: Alpha Rendering.Mar 22 2019, 8:24 AM

Jeroen Bakker (jbakker) mentioned this in T62772: erase alpha not shown in overlay mode.

Jeroen Bakker (jbakker) mentioned this in T58727: Mask Tool has no working visualization.