Fix T62774: Respect Show Overlays
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 22 2019, 11:26 AM.

Details

Reviewers

Clément Foucault (fclem)
William Reynish (billreynish)

Maniphest Tasks

T62774: Some Overlay sections do not respect Overlay On/Off toggle

Commits

rBS30fbf905ef8b: Fix T62774: Respect Show Overlays
rB30fbf905ef8b: Fix T62774: Respect Show Overlays

Summary

Some draw code did not respect Show Overlays option. These were:

All mode based drawing engines (edit mode)
Wireframe drawing

This change make them respect the Show Overlays Option. Please note that sculpt mode will show the sculpt mesh and currently can't show the render mesh as it is updated when the user leaves sculpt mode.

Diff Detail

Repository

rB Blender

Branch

T62774 (branched from master)

Build Status

Buildable 3215
Build 3215: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 22 2019, 11:26 AM

Harbormaster completed remote builds in B3215: Diff 14349.Mar 22 2019, 11:26 AM

Harbormaster completed remote builds in B3215: Diff 14349.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Mar 22 2019, 11:28 AM

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).

Jeroen Bakker (jbakker) added a subscriber: William Reynish (billreynish).

Seems good to me I think.

Just a thought: To make it easier to enable edit display or not, we could have a single parent toggle inside the overlays to turn on or off all edit mode overlays. They you could easily disable all overlays except editing overlays if you wanted to. Although perhaps that is not really necessary.

@Brecht Van Lommel (brecht) @Clément Foucault (fclem) What do you think?

This revision is now accepted and ready to land.Mar 22 2019, 11:37 AM

William Reynish (billreynish) added a subscriber: Brecht Van Lommel (brecht).Mar 22 2019, 1:03 PM

@William Reynish (billreynish) I don't think that's necessary. This is not the kind of settings you change all the time so you might setup a workspace with thoses settings. Also making such option would make the dependency between options a bit more convoluted.