Paths

Table of Contentst

Differential D4590

Fix T62887: When searching for fonts, thumbnail dispaly mode will crash Blender
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Mar 25 2019, 6:32 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rBSb2656a6ee4d5: Fix T62887: When searching for fonts, thumbnail display mode will crash Blender
rBb2656a6ee4d5: Fix T62887: When searching for fonts, thumbnail display mode will crash Blender

Summary

Don't crash with special fonts (like emoji fonts).

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) created this revision.Mar 25 2019, 6:32 PM

Sebastian Parborg (zeddb) mentioned this in T62887: When searching for fonts, thumbnail dispaly mode will crash Blender.

Not sure this correct, it seems 0 is a valid mode?
https://www.freetype.org/freetype2/docs/reference/ft2-base_interface.html#ft_kerning_mode

Right, I made a mistake, it should check for NULL

That's the same thing though, NULL equals 0? mode seems to be FT_UInt so not a pointer.

Third times the charm.

It was the search that failed an returned a NULL pointer.

Brecht Van Lommel (brecht) accepted this revision.Mar 25 2019, 10:06 PM

This revision is now accepted and ready to land.Mar 25 2019, 10:06 PM

Closed by commit rBb2656a6ee4d5: Fix T62887: When searching for fonts, thumbnail display mode will crash Blender (authored by Sebastian Parborg (zeddb)). · Explain WhyMar 26 2019, 2:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenfont/

intern/

6 lines

Diff 14410

source/blender/blenfont/intern/blf_glyph.c

Loading...