Crash When Shading Textures+Transparency
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 26 2019, 8:42 AM.

Details

Reviewers

Maniphest Tasks

T62874: Opening texture paint tab causes immediate crash

Commits

rBSaa0c864d4878: Fix T62874: Crash Texture shading+Transparency
rBaa0c864d4878: Fix T62874: Crash Texture shading+Transparency

Summary

When texure shading is enabled, the transparency accum shaders were not set/updated.
This resulted into a crash when transparent objects were rendered when shading mode
was set to texture.

This patch will add the V3D_SHADING_TEXTURE_COLOR to the modes for OIT so the
shaders are set.

@Clément Foucault (fclem) just a sanity check that this is valid. V3D_SHADING_MATERIAL_COLOR is a fallback for when no textures are available that can result enabling the OIT; Basically OIT is enabled for most cases. Only single and random does not.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 26 2019, 8:42 AM

Harbormaster completed remote builds in B3233: Diff 14418.Mar 26 2019, 8:42 AM

Jeroen Bakker (jbakker) retitled this revision from Fix T62874: Crash When Shading Textures+Transparency to Crash When Shading Textures+Transparency.Mar 26 2019, 8:48 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).

Jeroen Bakker (jbakker) added a project: BF Blender.

Jeroen Bakker (jbakker) added a subscriber: Clément Foucault (fclem).

Jeroen Bakker (jbakker) added a task: T62874: Opening texture paint tab causes immediate crash.Mar 26 2019, 3:22 PM

Clément Foucault (fclem) accepted this revision.Mar 28 2019, 2:50 PM

This revision is now accepted and ready to land.Mar 28 2019, 2:50 PM

Closed by commit rBaa0c864d4878: Fix T62874: Crash Texture shading+Transparency (authored by Jeroen Bakker (jbakker)). · Explain WhyMar 28 2019, 3:00 PM

This revision was automatically updated to reflect the committed changes.