Page MenuHome
Differential D4594

Fix T62955: Missing panels in workbench engine
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 26 2019, 1:38 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
William Reynish (billreynish)
Maniphest Tasks
T62955: Rigid Body World settings missing in Scene tab
Commits
rBS16a04dccd556: Fix T62955: Missing panels in workbench engine
rB16a04dccd556: Fix T62955: Missing panels in workbench engine
Summary

Afaik all the panels in the scene settings are render
engine independent. So it does not make sense to have
this extra complexity in every panel class.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 26 2019, 1:38 PM
Harbormaster completed remote builds in B3235: Diff 14421.Mar 26 2019, 1:39 PM
Jacques Lucke (JacquesLucke) added a task: T62955: Rigid Body World settings missing in Scene tab.Mar 26 2019, 1:42 PM
William Reynish (billreynish) requested changes to this revision.Mar 26 2019, 1:47 PM
William Reynish (billreynish) added a subscriber: William Reynish (billreynish).

I think this appears to remove the Custom Properties panel? Surely that's a mistake :) ?

I also wonder why the Rigid Body panels ever checked for the render engine. Seems to make no apparent sense, but perhaps it's simply a mistake.

This revision now requires changes to proceed.Mar 26 2019, 1:47 PM
Jacques Lucke (JacquesLucke) added a comment.Mar 26 2019, 2:13 PM

Ahhh, good catch. I was confused by the naming and thought this would be some custom property that is not used anymore. xD

Jacques Lucke (JacquesLucke) updated this revision to Diff 14423.Mar 26 2019, 2:28 PM
  • bring back custom properties panel
Harbormaster completed remote builds in B3236: Diff 14423.Mar 26 2019, 2:28 PM
Brecht Van Lommel (brecht) accepted this revision.Mar 26 2019, 3:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 26 2019, 3:43 PM
Closed by commit rB16a04dccd556: Fix T62955: Missing panels in workbench engine (authored by Jacques Lucke (JacquesLucke)). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
44 lines

Diff 14431

View Options

release/scripts/startup/bl_ui/properties_scene.py

Loading...