Page MenuHome

Crash when using Vertex/Weight Paint
AbandonedPublic

Authored by Jeroen Bakker (jbakker) on Mar 26 2019, 2:34 PM.

Details

Summary

Issue introduced by 40f8f445a3f9b6bc24b58e45be46060cc36c0394
It is not clear what the change tries to fix, so this patch is most likely only solving a symptom and not solving the root cause.

When performing a weightpaint the depth-tex is NULL.
The cause is that no selection is performed so....
What should the fix be:

  1. Do selection depth testing when painting. (DRW_draw_depth_loop)
  2. Use old technique when doing painting.
  3. other....

Diff Detail

Repository
rB Blender
Branch
T62965 (branched from master)
Build Status
Buildable 3237
Build 3237: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) retitled this revision from Fix T62965: Crash when using Vertex/Weight Paint to Crash when using Vertex/Weight Paint.Mar 26 2019, 2:37 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Strange the depth to be read without this texture having been created before.
I thought I had checked all the cases.
Apparently there is some part in the code reading the depth in the backbuffer.
The original intent was to remove the use of draw_depth_texture_to_screen and to have more freedom in choosing the texture resolution.
But as this turned out to be a can of worms, better revert that commit.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Mar 26 2019, 2:58 PM

Discussed in IRC to revert the original commit for now

Abandonned as we reverted the original commit.