Fix T60821: highlighting issues in Dope Sheet
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 28 2019, 1:43 PM.

Details

Reviewers

Joshua Leung (aligorith)
Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)

Maniphest Tasks

T60821: highlighting issues in Dope Sheet

Commits

rBS12417fcbf676: Fix T60821: highlighting issues in Dope Sheet
rB12417fcbf676: Fix T60821: highlighting issues in Dope Sheet

Summary

replaced check for 'object->flag & SELECT' with 'base->flag &
BASE_SELECTED'

Diff Detail

Repository

rB Blender

Branch

T60821_ (branched from master)

Build Status

Buildable 3248
Build 3248: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Mar 28 2019, 1:43 PM

Harbormaster completed remote builds in B3248: Diff 14457.Mar 28 2019, 1:43 PM

a bit more detail in T60821 itself...

object->flag & SELECT is not longer a thing , it's now ob->base_flag & BASE_SELECTED which is synced from base->flag & BASE_SELECTED by the depsgraph. The latter is preferred when possible.

This revision now requires changes to proceed.Apr 3 2019, 7:20 PM

review by brecht

Harbormaster completed remote builds in B3307: Diff 14669.Apr 8 2019, 11:50 AM

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Apr 8 2019, 11:51 AM

Brecht Van Lommel (brecht) accepted this revision.Apr 8 2019, 6:00 PM

This revision is now accepted and ready to land.Apr 8 2019, 6:00 PM

Closed by commit rB12417fcbf676: Fix T60821: highlighting issues in Dope Sheet (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 8 2019, 8:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

animation/

anim_channels_defines.c

2 lines

Diff 14457

View Options

source/blender/editors/animation/anim_channels_defines.c

Fix T60821: highlighting issues in Dope SheetClosedPublicActions