Page MenuHome
Differential D4630

Fix T62434: EEVEE not using correct World Output node
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 2 2019, 4:50 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Clément Foucault (fclem)
Maniphest Tasks
T62434: EEVEE not using correct World Output node
Commits
rBS96de11c2c67e: Fix T62434: EEVEE not using correct World Output node
rB96de11c2c67e: Fix T62434: EEVEE not using correct World Output node
Summary

We were already getting the designated output node in
'ntreeGPUMaterialNodes()' but this wasnt used in 'ntreeExecGPUNodes()',
instead whatever node was tagged NODE_DO_OUTPUT was executed.

note: this is just the bare minimum to fix the bug, other improvements
previously done in D4482 might follow as a separate commit.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Apr 2 2019, 4:50 PM
Harbormaster completed remote builds in B3263: Diff 14525.Apr 2 2019, 4:50 PM
Philipp Oeser (lichtwerk) added a comment.Apr 2 2019, 4:53 PM

made this separately from D4482 now, since T62351 seems fixed and this is a much simpler approach...

Clément Foucault (fclem) accepted this revision.Apr 2 2019, 4:57 PM

Looks good to me.

This revision is now accepted and ready to land.Apr 2 2019, 4:57 PM
Brecht Van Lommel (brecht) accepted this revision.Apr 2 2019, 5:00 PM
Closed by commit rB96de11c2c67e: Fix T62434: EEVEE not using correct World Output node (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 2 2019, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
shader/
2 lines
2 lines
4 lines
nodes/
2 lines

Diff 14526

View Options

source/blender/nodes/shader/node_shader_tree.c

Loading...
View Options

source/blender/nodes/shader/node_shader_util.h

Loading...
View Options

source/blender/nodes/shader/node_shader_util.c

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_common.c

Loading...