Page MenuHome
Differential D4642

Fix T63252: Bind in Mesh Deform Modifier fails
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Apr 4 2019, 2:44 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBS59f6371a8582: Fix T63252: Bind in Mesh Deform Modifier fails
rB59f6371a8582: Fix T63252: Bind in Mesh Deform Modifier fails
Summary

A regression since 64c8d72ef1ad.

The solution is to force modifier evaluation for an evaluated
object, and let it to copy binding data back to original when
is being evaluated for binding.

Diff Detail

Repository
rB Blender

Event Timeline

Sergey Sharybin (sergey) created this revision.Apr 4 2019, 2:44 PM
Harbormaster completed remote builds in B3278: Diff 14581.Apr 4 2019, 2:44 PM
Brecht Van Lommel (brecht) requested changes to this revision.Apr 4 2019, 3:04 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/object/object_modifier.c
2328

Not needed, already NULL.

source/blender/modifiers/intern/MOD_correctivesmooth.c
585–599

Move these lines 4 lines inside if (DEG_is_active(depsgraph)) too?

This revision now requires changes to proceed.Apr 4 2019, 3:04 PM
Sergey Sharybin (sergey) updated this revision to Diff 14583.Apr 4 2019, 3:37 PM

Update for Brecht's review

Also corrected wrong unbind error in the Surface Deform (it was raising
an error on every F12 when the modifier was never bound).

Harbormaster completed remote builds in B3280: Diff 14583.Apr 4 2019, 3:37 PM
Sergey Sharybin (sergey) marked an inline comment as done.Apr 4 2019, 3:39 PM
Sergey Sharybin (sergey) added inline comments.
source/blender/modifiers/intern/MOD_correctivesmooth.c
585–599

Probably, just to be consistent with other modifiers.

Sergey Sharybin (sergey) updated this revision to Diff 14584.Apr 4 2019, 3:39 PM
Sergey Sharybin (sergey) marked an inline comment as done.

Fix unbinding of Laplacian Deform

Harbormaster completed remote builds in B3281: Diff 14584.Apr 4 2019, 3:39 PM
Brecht Van Lommel (brecht) accepted this revision.Apr 4 2019, 3:46 PM
This revision is now accepted and ready to land.Apr 4 2019, 3:46 PM
Closed by commit rB59f6371a8582: Fix T63252: Bind in Mesh Deform Modifier fails (authored by Sergey Sharybin (sergey)). · Explain WhyApr 4 2019, 3:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
10 lines
intern/
20 lines
editors/
armature/
16 lines
object/
92 lines
modifiers/
intern/
27 lines
18 lines
36 lines

Diff 14585

View Options

source/blender/blenkernel/BKE_modifier.h

Loading...
View Options

source/blender/blenkernel/intern/modifier.c

Loading...
View Options

source/blender/editors/armature/meshlaplacian.c

Loading...
View Options

source/blender/editors/object/object_modifier.c

Loading...
View Options

source/blender/modifiers/intern/MOD_correctivesmooth.c

Loading...
View Options

source/blender/modifiers/intern/MOD_meshdeform.c

Loading...
View Options

source/blender/modifiers/intern/MOD_surfacedeform.c

Loading...