This patch fixes T63227 by allowing to import .ply with vertex color when the alpha isn't specified.
Details
Details
Diff Detail
Diff Detail
- Repository
- rBA Blender Add-ons
Event Timeline
Comment Actions
Generally seems to work. I'd just like to see code that is a little bit more specific here, does that make sense?
| io_mesh_ply/import_ply.py | ||
|---|---|---|
| 279 | trailing whitespace (you can configure your editor so that trailing whitespace is removed automatically when you save) | |
| 280 | I think it would be better to make sure that mesh_colors always contains rgba data. Also, the readability of this nested list comprehension is fairly low imo. Better be more explicit about what is happening here (by "unrolling" the loop a bit). | |
| io_mesh_ply/import_ply.py | ||
|---|---|---|
| 259 | do vertices have to have colors? | |
Comment Actions
Removed the print. Should there be a message if fewer color channels than RGB are present?
| io_mesh_ply/import_ply.py | ||
|---|---|---|
| 259 | You're right, I was bit too quick on this one. | |
Comment Actions
Hm, yes. Something like Warning: One obligatory color channel is missing, ignoring vertex colors.
Comment Actions
- Warning when vertex color is ignored because a color channel is there, but not all of the required R, G and B are present
Comment Actions
just create another patch.
Btw, can you use arcanist to upload the patches?
Where is the mistake?
This comment was removed by J. Gregory (visionarymind).