GPU not able to allocate texture
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Apr 5 2019, 12:54 PM.

Details

Reviewers

Clément Foucault (fclem)
Brecht Van Lommel (brecht)

Maniphest Tasks

T63223: blender 2.8

Commits

rBS6de0da70de30: GPU not able to allocate texture
rB6de0da70de30: GPU not able to allocate texture

Summary

GL_PROXY_TEXTURE_2D_ARRAY of 2509x2509x1 fails to be allocated.
This is the texture size of when allocating a shadow cubemap map with the size of 1024.
Not sure this is a full fix, but with these changes the scene renders fine.

NOTE: I only needed to update the GL_PROXY_TEXTURE change. the GL_TEXTURE_ I updated to make the code similar, but it is not needed to fix the issue

Fix: T63223

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Apr 5 2019, 12:54 PM

Harbormaster completed remote builds in B3285: Diff 14616.Apr 5 2019, 12:55 PM

Brecht Van Lommel (brecht) accepted this revision.Apr 5 2019, 12:59 PM

This revision is now accepted and ready to land.Apr 5 2019, 12:59 PM

Jeroen Bakker (jbakker) added 1 blocking reviewer(s): Clément Foucault (fclem).Apr 5 2019, 1:02 PM

This revision now requires review to proceed.Apr 5 2019, 1:02 PM

Seems I didn't fully understand the change, will leave it to you guys to figure out.

If that helps workaround the problem I may be Ok to use GL_PROXY_TEXTURE_2D_ARRAY only if d > 1; but for completeness the final texture NEEDS to be GL_TEXTURE_2D_ARRAY. This is because the sampler is a sampler2DArray and binding a 2D texture will surely trigger an error. The Proxy texture mechanism is kindof broken in some cases.

Code review comments

Harbormaster completed remote builds in B3287: Diff 14622.Apr 5 2019, 2:32 PM

If proxy and non-proxy are different, there should at least be a comment explaining why this was done.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2019, 2:43 PM

Closed by commit rB6de0da70de30: GPU not able to allocate texture (authored by Jeroen Bakker (jbakker)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

intern/

gpu_texture.c

2 lines

Diff 14624

View Options

source/blender/gpu/intern/gpu_texture.c

GPU not able to allocate textureClosedPublicActions