Page MenuHome

Fix T63283: Second subdivision modifier does not ignore crease
ClosedPublic

Authored by Sergey Sharybin (sergey) on Apr 5 2019, 2:15 PM.

Details

Summary

This is something where there is no single correct behavior,
sometimes it's needed to ignore the crease to make mesh more
smooth. But sometimes crease is to be considered after first
subdivision surface: for example, when adding extra subdivisions
for render-time displacement.

Made it an option whether modifier needs to take crease into
account or not.

Existing files should be openable in the 2.7 compatible way,
to re-create an old behavior the options is to be manually
disabled in the modifier settings.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Apr 5 2019, 2:27 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/blenloader/intern/versioning_280.c
2980

&= -> &= ~

2990

&= -> &= ~

source/blender/makesrna/intern/rna_modifier.c
1282

use_crease -> use_creases would be a better name I think.

1284

Perhaps more descriptive: Use mesh edge crease information to sharpen edges.

This revision now requires changes to proceed.Apr 5 2019, 2:27 PM

Update for Brecht's review

This revision is now accepted and ready to land.Apr 5 2019, 2:43 PM
This revision was automatically updated to reflect the committed changes.

https://blender.community/c/rightclickselect/hwcbbc/
Next time I'll know what I need to do a bug report, not a proposal for rightclickselect :)
But I'm glad it's done. Thanks.