Page MenuHome
Differential D4665

Fix T63429: Random deselect function lost
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Apr 9 2019, 9:32 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Maniphest Tasks
T63429: Random deselect function lost
Commits
rBS423d9086e64e: Fix T63429: Random deselect function lost
rB423d9086e64e: Fix T63429: Random deselect function lost
Summary

Add back the ability to choose the select operation for random select.

This was changed in rB98e0bd90f45fd04ebba5c623ea6d2ff5e12f073a so I'm unsure if this was intentional or not.
There doesn't seem to be an easy way to get to this setting anymore (without using python).

Diff Detail

Repository
rB Blender

Event Timeline

Sebastian Parborg (zeddb) created this revision.Apr 9 2019, 9:32 PM
Sebastian Parborg (zeddb) added a task: T63429: Random deselect function lost.
Brecht Van Lommel (brecht) requested changes to this revision.EditedApr 9 2019, 9:39 PM

It was intentional for most selection operators. But for WM_operator_properties_select_random we can keep this visible in the UI.

This revision now requires changes to proceed.Apr 9 2019, 9:39 PM
Sebastian Parborg (zeddb) added a comment.Apr 9 2019, 10:02 PM

@Brecht Van Lommel (brecht) I'm guessing you wanted to accept the changes?

Brecht Van Lommel (brecht) added a comment.EditedApr 9 2019, 10:14 PM

No, this change seems to bring the property back in UI for more selection tools than just select random. It should only be for select random.

Sebastian Parborg (zeddb) updated this revision to Diff 14703.Apr 11 2019, 8:16 PM

Updated so that the operator call now has a flag to toggle on and off the visibility.

Brecht Van Lommel (brecht) accepted this revision.Apr 16 2019, 12:00 AM
This revision is now accepted and ready to land.Apr 16 2019, 12:00 AM
Closed by commit rB423d9086e64e: Fix T63429: Random deselect function lost (authored by Sebastian Parborg (zeddb)). · Explain WhyApr 16 2019, 1:16 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) mentioned this in T68122: Settings for Select root and Select tip in particle edit mode are missing.Aug 2 2019, 12:31 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
physics/
4 lines
space_info/
2 lines
windowmanager/
4 lines
intern/
20 lines

Diff 14753

View Options

source/blender/editors/physics/particle_edit.c

Loading...
View Options

source/blender/editors/space_info/info_report.c

Loading...
View Options

source/blender/windowmanager/WM_api.h

Loading...
View Options

source/blender/windowmanager/intern/wm_operator_props.c

Loading...