Page MenuHome

Fix T62449: Subsurf+hidden faces
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Apr 10 2019, 9:55 AM.

Details

Summary

When using subsurf (and other modifiers) the edit flags are not
propagated correctly. Currently we assume to read the edit flags
from the original object which is kind off hinding the real issue.

Modifiers use mesh_new_nomain_from_template_ex to create a copy
from an existing mesh. this method is only used by modifiers. So
by placing this we will make sure that editmesh is propagated.

IMO Ideally the draw manager should work fully on the depgraph object and
not check the state of the original object, this will need additional
refactoring and testing.

Diff Detail

Repository
rB Blender
Branch
T62449 (branched from master)
Build Status
Buildable 3311
Build 3311: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) retitled this revision from Fix T62449: Subsurf+hiden faces to Fix T62449: Subsurf+hidden faces.Apr 10 2019, 9:58 AM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Think it's all fine.

This revision is now accepted and ready to land.Apr 10 2019, 10:20 AM
This revision was automatically updated to reflect the committed changes.