Paths

Table of Contentst

Differential D4699

Overlay Engine: Option to Disable AA Ortho Grid
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Apr 17 2019, 12:11 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)
Clément Foucault (fclem)

Maniphest Tasks

T63517: Separate grid and floor overlay settings for 3D viewport

Commits

rBS63bae864f403: Overlay Engine: Option to Disable AA Ortho Grid
rB63bae864f403: Overlay Engine: Option to Disable AA Ortho Grid

Summary

When in Axis alligned orthographic view a grid was always displayed.
With this change the user can enable/disable this grid.

The Grid is always visible and editable, but only rendered active when user is in quad view, or axis aligned ortho view.

I am not 100% sure about the API. Should we do a specific is_axis_aligned read only boolean or should we make the view enum visible in the API?

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Apr 17 2019, 12:11 PM

Harbormaster completed remote builds in B3348: Diff 14775.Apr 17 2019, 12:11 PM

Jeroen Bakker (jbakker) added inline comments.Apr 17 2019, 12:13 PM

source/blender/makesrna/intern/rna_space.c
3791	Do we want this in the API, or do we want to add the view property in its whole?

Jeroen Bakker (jbakker) added reviewers: Brecht Van Lommel (brecht), Clément Foucault (fclem).Apr 17 2019, 1:48 PM

Clément Foucault (fclem) accepted this revision.Apr 17 2019, 1:57 PM

This revision is now accepted and ready to land.Apr 17 2019, 1:57 PM

Wait a moment before committing this, I want to review this still.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Apr 17 2019, 2:29 PM

Jeroen Bakker (jbakker) added 1 blocking reviewer(s): Brecht Van Lommel (brecht).Apr 17 2019, 3:47 PM

This revision now requires review to proceed.Apr 17 2019, 3:47 PM

Great to see these all your assigned tasks getting solved so quickly :)

release/scripts/startup/bl_ui/space_view3d.py
4838–4851	These settings also have an effect for ortho side views. So `overlay.show_floor` should be `overlay.show_floor or overlay.show_ortho_grid` here.
source/blender/makesrna/intern/rna_space.c
2942	othographics axis aligned view -> orthographic side views Axis aligned is more a programming term.
3791	I'm fine having this in the API. But I would call it `is_orthographic_side_view` and not introduce new terminology.

This revision now requires changes to proceed.Apr 17 2019, 7:29 PM

Solved comments from code review

Harbormaster completed remote builds in B3362: Diff 14796.Apr 18 2019, 8:45 AM

Missed one

Harbormaster completed remote builds in B3363: Diff 14797.Apr 18 2019, 8:49 AM

Brecht Van Lommel (brecht) accepted this revision.Apr 18 2019, 9:59 AM

This revision is now accepted and ready to land.Apr 18 2019, 9:59 AM

Closed by commit rB63bae864f403: Overlay Engine: Option to Disable AA Ortho Grid (authored by Jeroen Bakker (jbakker)). · Explain WhyApr 18 2019, 11:23 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_view3d.py

22 lines

source/

blender/

blenloader/

intern/

versioning_280.c

12 lines

draw/

modes/

7 lines

editors/

space_view3d/

2 lines

makesdna/

DNA_view3d_types.h

1 line

makesrna/

intern/

16 lines

Diff 14800

release/scripts/startup/bl_ui/space_view3d.py

Loading...

source/blender/blenloader/intern/versioning_280.c

Loading...

source/blender/draw/modes/object_mode.c

Loading...

source/blender/editors/space_view3d/space_view3d.c

Loading...

source/blender/makesdna/DNA_view3d_types.h

Loading...

source/blender/makesrna/intern/rna_space.c

Loading...