Details

Reviewers

Commits

rBS8f4ba1c0467d: Fix T63669: Particle editing bypassing occlusion.
rB8f4ba1c0467d: Fix T63669: Particle editing bypassing occlusion.

Summary

The problem occurs because of the status changes between BackBuffer and Offscreen.
This patch moves all remaining depth drawing to the Offscreen.

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Apr 17 2019, 10:43 PM

Harbormaster completed remote builds in B3358: Diff 14791.Apr 17 2019, 10:43 PM

Remove changes in GHOST (this is for another review).

Harbormaster completed remote builds in B3359: Diff 14792.Apr 17 2019, 11:16 PM

Harbormaster completed remote builds in B3359: Diff 14792.

Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)Apr 17 2019, 11:17 PM

Cleanup: Remove unused function.

Harbormaster completed remote builds in B3370: Diff 14808.Apr 18 2019, 4:07 PM

With this patch the depth obtained with DRW_draw_depth_object is quickly overwritten by the depth of the entire scene.

Use g_select_buffer.texture_depth instead Viewport depth.

Harbormaster completed remote builds in B3376: Diff 14816.Apr 18 2019, 10:25 PM

Revert "Use g_select_buffer.texture_depth instead Viewport depth."
Remove draw_depth_texture_to_screen;
Remover redundant GL_SCISSOR_TEST

Harbormaster completed remote builds in B3381: Diff 14822.Apr 19 2019, 2:39 PM

The patch is ready, but there is a problem with Clip Plans though.
Since the problem is in Shader it is better to solve in another patch.

Cleanup.

Harbormaster completed remote builds in B3385: Diff 14826.Apr 19 2019, 3:42 PM

Clément Foucault (fclem) accepted this revision.Apr 19 2019, 4:05 PM

This revision is now accepted and ready to land.Apr 19 2019, 4:05 PM

Closed by commit rB8f4ba1c0467d: Fix T63669: Particle editing bypassing occlusion. (authored by Germano Cavalcante (mano-wii)). · Explain WhyApr 19 2019, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Fix T63669: Occlusion not workink on particle editing.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 14828

source/blender/draw/DRW_engine.h

source/blender/draw/intern/draw_manager.c

source/blender/editors/include/ED_view3d.h

source/blender/editors/space_view3d/drawobject.c

source/blender/editors/space_view3d/view3d_draw_legacy.c

source/blender/editors/space_view3d/view3d_intern.h

Fix T63669: Occlusion not workink on particle editing.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14828

source/blender/draw/DRW_engine.h

source/blender/draw/intern/draw_manager.c

source/blender/editors/include/ED_view3d.h

source/blender/editors/space_view3d/drawobject.c

source/blender/editors/space_view3d/view3d_draw_legacy.c

source/blender/editors/space_view3d/view3d_intern.h

Fix T63669: Occlusion not workink on particle editing.
ClosedPublic
Actions

Revision Contents
Changeset List